From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37407) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inQrk-000777-W9 for guix-patches@gnu.org; Fri, 03 Jan 2020 12:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inQrj-0003AP-Le for guix-patches@gnu.org; Fri, 03 Jan 2020 12:36:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inQrj-000398-H0 for guix-patches@gnu.org; Fri, 03 Jan 2020 12:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inQrj-0008Gp-CR for guix-patches@gnu.org; Fri, 03 Jan 2020 12:36:03 -0500 Subject: [bug#38902] [PATCH 3/9] services: nfs: Allow rpcbind-service-type to be extended. Resent-Message-ID: From: Ricardo Wurmus Message-ID: <20200103173506.9779-3-rekado@elephly.net> Date: Fri, 3 Jan 2020 18:35:00 +0100 In-Reply-To: <20200103173506.9779-1-rekado@elephly.net> References: <20200103173506.9779-1-rekado@elephly.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38902@debbugs.gnu.org Cc: Ricardo Wurmus * gnu/services/nfs.scm (rpcbind-service-type): Rewrite using SERVICE-TYPE t= o add ability to extend the service. --- gnu/services/nfs.scm | 47 ++++++++++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/gnu/services/nfs.scm b/gnu/services/nfs.scm index 834e94a800..0681e764ec 100644 --- a/gnu/services/nfs.scm +++ b/gnu/services/nfs.scm @@ -56,23 +56,36 @@ (default #t))) =20 (define rpcbind-service-type - (shepherd-service-type - 'rpcbind - (lambda (config) - (define rpcbind - (rpcbind-configuration-rpcbind config)) - - (define rpcbind-command - #~(list (string-append #$rpcbind "/bin/rpcbind") "-f" - #$@(if (rpcbind-configuration-warm-start? config) '("-w") '= ()))) - - (shepherd-service - (documentation "Start the RPC bind daemon.") - (requirement '(networking)) - (provision '(rpcbind-daemon)) - - (start #~(make-forkexec-constructor #$rpcbind-command)) - (stop #~(make-kill-destructor)))))) + (let ((proc + (lambda (config) + (define rpcbind + (rpcbind-configuration-rpcbind config)) + + (define rpcbind-command + #~(list (string-append #$rpcbind "/bin/rpcbind") "-f" + #$@(if (rpcbind-configuration-warm-start? config) '("= -w") '()))) + + (shepherd-service + (documentation "Start the RPC bind daemon.") + (requirement '(networking)) + (provision '(rpcbind-daemon)) + + (start #~(make-forkexec-constructor #$rpcbind-command)) + (stop #~(make-kill-destructor)))))) + (service-type + (name 'rpcbind) + (extensions + (list (service-extension shepherd-root-service-type + (compose list proc)))) + ;; We use the extensions feature to allow other services to automatic= ally + ;; configure and start this service. Only one value can be provided.= We + ;; override it with the value returned by the extending service. + (compose identity) + (extend (lambda (config values) + (match values + ((first . rest) first) + (_ config)))) + (default-value (rpcbind-configuration))))) =20 =0C =20 --=20 2.24.1