unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38765] [PATCH] Add C++ bindings to Portaudio
@ 2019-12-27 18:39 Nicolas Goaziou
  2019-12-28 19:54 ` Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2019-12-27 18:39 UTC (permalink / raw)
  To: 38765

[-- Attachment #1: Type: text/plain, Size: 107 bytes --]

Hello,

The following patch enables C++ bindings for our Portaudio package.

Regards,

-- 
Nicolas Goaziou

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add C++ bindings --]
[-- Type: text/x-diff, Size: 1286 bytes --]

From a771f96fc319e1ece917532253c44b57494d0e32 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Fri, 27 Dec 2019 19:33:50 +0100
Subject: [PATCH] gnu: portaudio: Add C++ bindings.

* gnu/packages/audio.scm (portaudio): Add C++ bindings, aka "portaudiocpp".
---
 gnu/packages/audio.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 76c59f33cc..73235ef292 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2872,8 +2872,13 @@ portions of LAME.")
        ("libtool" ,libtool)
        ("pkg-config" ,pkg-config)))
     (arguments
-     '(#:tests? #f                    ;no 'check' target
-       #:configure-flags '("--with-pic")
+     '(#:tests? #f                      ;no 'check' target
+       #:configure-flags '("--with-pic"
+                           "--enable-cxx"
+                           ;; XXX: The following prevents a build error
+                           ;; because of missing depcomp when C++ bindings are
+                           ;; requested.
+                           "--disable-dependency-tracking")
        #:phases
        (modify-phases %standard-phases
          ;; This is needed for linking the static libraries
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#38765] [PATCH] Add C++ bindings to Portaudio
  2019-12-27 18:39 [bug#38765] [PATCH] Add C++ bindings to Portaudio Nicolas Goaziou
@ 2019-12-28 19:54 ` Efraim Flashner
  2019-12-28 20:22   ` bug#38765: " Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2019-12-28 19:54 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 38765

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

LGTM!


On Fri, Dec 27, 2019 at 07:39:48PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> The following patch enables C++ bindings for our Portaudio package.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou

> From a771f96fc319e1ece917532253c44b57494d0e32 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Fri, 27 Dec 2019 19:33:50 +0100
> Subject: [PATCH] gnu: portaudio: Add C++ bindings.
> 
> * gnu/packages/audio.scm (portaudio): Add C++ bindings, aka "portaudiocpp".
> ---
>  gnu/packages/audio.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 76c59f33cc..73235ef292 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -2872,8 +2872,13 @@ portions of LAME.")
>         ("libtool" ,libtool)
>         ("pkg-config" ,pkg-config)))
>      (arguments
> -     '(#:tests? #f                    ;no 'check' target
> -       #:configure-flags '("--with-pic")
> +     '(#:tests? #f                      ;no 'check' target
> +       #:configure-flags '("--with-pic"
> +                           "--enable-cxx"
> +                           ;; XXX: The following prevents a build error
> +                           ;; because of missing depcomp when C++ bindings are
> +                           ;; requested.
> +                           "--disable-dependency-tracking")
>         #:phases
>         (modify-phases %standard-phases
>           ;; This is needed for linking the static libraries
> -- 
> 2.24.1
> 


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#38765: [PATCH] Add C++ bindings to Portaudio
  2019-12-28 19:54 ` Efraim Flashner
@ 2019-12-28 20:22   ` Nicolas Goaziou
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2019-12-28 20:22 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 38765-done

Hello,

Efraim Flashner <efraim@flashner.co.il> writes:

> LGTM!

Pushed as 1ce6bfc21ce328d787df76c6ee132f9f828d098b. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-28 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-27 18:39 [bug#38765] [PATCH] Add C++ bindings to Portaudio Nicolas Goaziou
2019-12-28 19:54 ` Efraim Flashner
2019-12-28 20:22   ` bug#38765: " Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).