unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 38765@debbugs.gnu.org
Subject: [bug#38765] [PATCH] Add C++ bindings to Portaudio
Date: Sat, 28 Dec 2019 21:54:23 +0200	[thread overview]
Message-ID: <20191228195423.GS23018@E5400> (raw)
In-Reply-To: <87a77d3957.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

LGTM!


On Fri, Dec 27, 2019 at 07:39:48PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> The following patch enables C++ bindings for our Portaudio package.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou

> From a771f96fc319e1ece917532253c44b57494d0e32 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Fri, 27 Dec 2019 19:33:50 +0100
> Subject: [PATCH] gnu: portaudio: Add C++ bindings.
> 
> * gnu/packages/audio.scm (portaudio): Add C++ bindings, aka "portaudiocpp".
> ---
>  gnu/packages/audio.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 76c59f33cc..73235ef292 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -2872,8 +2872,13 @@ portions of LAME.")
>         ("libtool" ,libtool)
>         ("pkg-config" ,pkg-config)))
>      (arguments
> -     '(#:tests? #f                    ;no 'check' target
> -       #:configure-flags '("--with-pic")
> +     '(#:tests? #f                      ;no 'check' target
> +       #:configure-flags '("--with-pic"
> +                           "--enable-cxx"
> +                           ;; XXX: The following prevents a build error
> +                           ;; because of missing depcomp when C++ bindings are
> +                           ;; requested.
> +                           "--disable-dependency-tracking")
>         #:phases
>         (modify-phases %standard-phases
>           ;; This is needed for linking the static libraries
> -- 
> 2.24.1
> 


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-12-28 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27 18:39 [bug#38765] [PATCH] Add C++ bindings to Portaudio Nicolas Goaziou
2019-12-28 19:54 ` Efraim Flashner [this message]
2019-12-28 20:22   ` bug#38765: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191228195423.GS23018@E5400 \
    --to=efraim@flashner.co.il \
    --cc=38765@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).