From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54091) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikN5w-00013L-3F for guix-patches@gnu.org; Thu, 26 Dec 2019 01:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikN5u-0001S9-Li for guix-patches@gnu.org; Thu, 26 Dec 2019 01:58:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikN5u-0001Rt-Hd for guix-patches@gnu.org; Thu, 26 Dec 2019 01:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikN5u-0005EM-Fq for guix-patches@gnu.org; Thu, 26 Dec 2019 01:58:02 -0500 Subject: [bug#38744] [PATCH] adding copyq 3.9.3 to xdisorg.scm Resent-Message-ID: Date: Thu, 26 Dec 2019 08:56:54 +0200 From: Efraim Flashner Message-ID: <20191226065654.GI23018@E5400> References: <3ba0f830-f7d1-3301-a1a6-99a045735dd0@moncourriel.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PEfPc/DjvCj+JzNg" Content-Disposition: inline In-Reply-To: <3ba0f830-f7d1-3301-a1a6-99a045735dd0@moncourriel.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thierry Cc: 38744@debbugs.gnu.org --PEfPc/DjvCj+JzNg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thank you for your patch! A couple of comments inline. On Wed, Dec 25, 2019 at 10:07:24PM +0100, Thierry wrote: >=20 > From 3e5fb3f5fc852b0f512b6771c6950f4947f66dd7 Mon Sep 17 00:00:00 2001 > From: Grillon > Date: Wed, 25 Dec 2019 21:22:42 +0100 > Subject: [PATCH] gnu: copyq(clipboard manager): added v3.9.3 >=20 > * gnu/packages/xdisorg.scm (copyq): added from 3.9.3 > --- > gnu/packages/xdisorg.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm > index b1759eabb2..9ee713de2f 100644 > --- a/gnu/packages/xdisorg.scm > +++ b/gnu/packages/xdisorg.scm > @@ -85,6 +85,7 @@ > #:use-module (gnu packages guile) > #:use-module (gnu packages xml) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages qt) > #:use-module (gnu packages xorg) > #:use-module (gnu packages fontutils) > #:use-module (gnu packages bison) > @@ -229,6 +230,34 @@ with X11 or Wayland, or in a text terminal with ncur= ses.") > (license (list license:gpl3+ ; client program[s] and other so= urces > license:lgpl3+)))) ; library and bindings > =20 > +(define-public copyq > +(package > + (name "copyq") > + (version "3.9.3") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/hluk/CopyQ/archive/v= " version > + ".tar.gz")) tarballs from github with the '/archive/' string are autogenerated and can be regenerated in the future, leading to a hash mismatch. I checked the release page and it looks like our best option is to use the .zip file. (This also means you'll need to add unzip to native-inputs) > + (sha256 > + (base32 > + "154yccvlyhr6dml29cvkaqi8277vshmpydvy6ar125qm74q2rib5")))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease") > + #:tests? #f)) Are there no tests or can the test suite not be run? Please leave a note :) > + (inputs `(("qtbase" ,qtbase) > + ("qtx11extras" ,qtx11extras) > + ("qtsvg" ,qtsvg) > + ("qtscript" ,qtscript))) > + (synopsis "Good qt clipboard manager") Go ahead and change this to something else. Checking the repo I'd go with "Clipboard manager with advanced features". > + (description "CopyQ is clipboard manager =E2=80=93 > + a desktop application which stores content of the system clipboard > + whenever it changes and allows to search the history > + and copy it back to the system clipboard > + or paste it directly to other applications.") Unfortunately the description reads to me like bad poetry :p I copied some text from the repo and re-wrapped it below: (description "CopyQ is clipboard manager with editing and scripting features. CopyQ monitors system clipboard and saves its content in customi= zed tabs. Saved clipboard can be later copied and pasted directly into any application.) > + (home-page "https://hluk.github.io/CopyQ/") > + (license license:gpl3+))) > + > (define-public xclip > (package > (name "xclip") > --=20 > 2.24.1 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --PEfPc/DjvCj+JzNg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4EWbMACgkQQarn3Mo9 g1EjqQ//dBwxcN4+cMDLxQace0VQmLTaYX1McxnhpcjKDsC9p4WAK8CBtclaBKS3 zaj6DEAxYvlBpDkL4ROzK2I9ivVgl0dXZcnHRPNk4PxD4h3nRz9WGd+8yPJ0Bo3Q j++H7VLiEEfgnT6pBnPTQomzfqlGtc79by8cMpek/hVbJV+zdbk3vbUWXSWrmrfy mvAPjsHTGpf1FmcTFQRp10770SdpqiDVOGfc+oNp6sL7b6eAZ2+NKiPqnoUd/gse hNPoKfxRQMuFVpROHzEtHBJWdoBMmTKNy+B3+38She0zuxiFfbkq9GCGZ0Ta96OA gwFrfOtzY+M9vp0Q+RhPpcGZxpQ3yjJUA43jHl0NLOVs8s84p7FAPXkjNLwdRGdd Vm2+8vWPoAYgoESVqgO3EcQ7r2hP1qI4x15IkDQb2MiFan3ea7IaprGdGOyHTMAE zF/PRXSQpFrFHamFkEvxWJCSDOc9XD66jBGO2XmMjwiti86lk8hBFAEUrMBifBlL MUpNrxyRUFjYUnuw0bOqKf1vWfU2IFmfpi5D5OzpNWfvuLxWCLm7K7CjxP5gU91m HAbaTDuVPWhuQKnXg4L7cBFOHkfPmIqaHkEBM671MUipGl1ubs10bzPTiwO9aJDx zGQAXuBtjvRyVDq8jNoZxEDM+jIV1idzHBa4KkNdccbCQOQ3nNs= =wUQf -----END PGP SIGNATURE----- --PEfPc/DjvCj+JzNg--