From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:38851)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiy2p-0002UC-L4
 for guix-patches@gnu.org; Sun, 22 Dec 2019 05:01:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiy2o-0001A8-Lq
 for guix-patches@gnu.org; Sun, 22 Dec 2019 05:01:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:43108)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iiy2o-00016H-04
 for guix-patches@gnu.org; Sun, 22 Dec 2019 05:01:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiy2n-0005Mf-TQ
 for guix-patches@gnu.org; Sun, 22 Dec 2019 05:01:01 -0500
Subject: [bug#38670] [PATCH] Fix audio/video in icecat
Resent-Message-ID: <handler.38670.B38670.157700883420576@debbugs.gnu.org>
Date: Sun, 22 Dec 2019 11:00:24 +0100
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20191222105928.53f03e2c@sybil.lepiller.eu>
In-Reply-To: <87lfr57yi4.fsf@netris.org>
References: <20191219145922.715720ad@sybil.lepiller.eu>
 <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 38670@debbugs.gnu.org

Le Sat, 21 Dec 2019 23:52:08 -0500,
Mark H Weaver <mhw@netris.org> a =C3=A9crit :

> Hi Julien,
>=20
> Thanks very much for investigating and producing a working fix for
> this issue!  It is a great relief to remove this item from my TODO
> list :)
>=20
> I have a few minor nits, and am currently testing a slight variant of
> your proposed patch, attached below.  I made the following changes:
>=20
> * I added a new phase instead of augmenting the existing
>   'link-libxul-with-libraries' phase, since the name of the existing
>   phase doesn't match what's being done here.
>=20
> * I leave the numeric suffixes (version number) of the shared library
>   names unchanged, instead of stripping them as you did.
>=20
> * I used "\\." in the regexp to strictly match that character.
>=20
> * I moved the rationale comment from the commit log into the code.
>=20
> What do you think?

Looks very good! Can you push it, or should I do it?

>=20
>    Thanks again!
>        Mark
>=20
>=20