unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: 38304@debbugs.gnu.org
Subject: [bug#38304] [PATCH]: Make more services one-shot
Date: Wed, 20 Nov 2019 21:45:44 +0200	[thread overview]
Message-ID: <20191120194544.GV15074@E5400> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 321 bytes --]

After changing the sysctl service to use one-shot I found 3 more that
look like they'd be good choices.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #1.2: 0001-services-host-name-Make-service-one-shot.patch --]
[-- Type: text/plain, Size: 957 bytes --]

From 64126d7a861a415bf4faafb30687928742db4f2b Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Wed, 20 Nov 2019 21:36:56 +0200
Subject: [PATCH 1/3] services: host-name: Make service one-shot.

* gnu/services/base.scm (host-name-service-type): Remove 'respawn?'
keyword from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index b1eff89ecc..7cd42bb30a 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -705,7 +705,7 @@ to add @var{device} to the kernel's entropy pool.  The service will fail if
       (provision '(host-name))
       (start #~(lambda _
                  (sethostname #$name)))
-      (respawn? #f)))))
+      (one-shot? #t)))))
 
 (define (host-name-service name)
   "Return a service that sets the host name to @var{name}."
-- 
2.24.0


[-- Attachment #1.3: 0002-services-console-keymap-service-type-Make-service-on.patch --]
[-- Type: text/plain, Size: 995 bytes --]

From 6c13de1914503afb3533a0fe032b4db767011874 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Wed, 20 Nov 2019 21:38:18 +0200
Subject: [PATCH 2/3] services: console-keymap-service-type: Make service
 one-shot.

* gnu/services/base.scm (console-keymap-service-type): Remove 'respawn?'
keyword from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 7cd42bb30a..022bb501ba 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -746,7 +746,7 @@ to add @var{device} to the kernel's entropy pool.  The service will fail if
       (start #~(lambda _
                  (zero? (system* #$(file-append kbd "/bin/loadkeys")
                                  #$@files))))
-      (respawn? #f)))))
+      (one-shot? #t)))))
 
 (define-deprecated (console-keymap-service #:rest files)
   #f
-- 
2.24.0


[-- Attachment #1.4: 0003-services-console-font-shepherd-services-Make-service.patch --]
[-- Type: text/plain, Size: 1054 bytes --]

From 153d02caa1333788df435ca4ffbf915c50d9cb01 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Wed, 20 Nov 2019 21:40:50 +0200
Subject: [PATCH 3/3] services: console-font-shepherd-services: Make service
 one-shot.

* gnu/services/base.scm (console-font-shepherd-services): Remove 'stop'
and 'respawn?' keywords from shepherd-service-type, add 'one-shot?'.
---
 gnu/services/base.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 022bb501ba..cef2d4cb2b 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -797,8 +797,7 @@ to add @var{device} to the kernel's entropy pool.  The service will fail if
                                         "-C" #$device #$font))
                           ((0 71) #t)
                           (else #f))))
-             (stop #~(const #t))
-             (respawn? #f)))))
+             (one-shot? #t)))))
        tty+font))
 
 (define console-font-service-type
-- 
2.24.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2019-11-20 19:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 19:45 Efraim Flashner [this message]
2019-11-20 19:54 ` [bug#38304] [PATCH]: Make more services one-shot Efraim Flashner
2019-12-08 21:28   ` Ludovic Courtès
2019-12-13 20:50     ` Efraim Flashner
2019-12-29  8:06       ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120194544.GV15074@E5400 \
    --to=efraim@flashner.co.il \
    --cc=38304@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).