From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46476) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXVcX-0002F6-7c for guix-patches@gnu.org; Wed, 20 Nov 2019 14:26:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXVcW-0006dh-1n for guix-patches@gnu.org; Wed, 20 Nov 2019 14:26:33 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXVcV-0006d9-Sx for guix-patches@gnu.org; Wed, 20 Nov 2019 14:26:31 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXVcV-0007Nz-Iq for guix-patches@gnu.org; Wed, 20 Nov 2019 14:26:31 -0500 Subject: bug#38240: [PATCH v3] services: sysctl: Make service one-shot. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Wed, 20 Nov 2019 21:24:52 +0200 From: Efraim Flashner Message-ID: <20191120192452.GU15074@E5400> References: <20191116214206.20590-1-efraim@flashner.co.il> <20191118082111.GF15074@E5400> <877e3wryis.fsf@gnu.org> <20191119100053.GP15074@E5400> <878soaprim.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K5z5w9fsx/Hrkgg3" Content-Disposition: inline In-Reply-To: <878soaprim.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38240-done@debbugs.gnu.org --K5z5w9fsx/Hrkgg3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2019 at 03:10:57PM +0100, Ludovic Court=C3=A8s wrote: > Hello! >=20 > Efraim Flashner skribis: >=20 > > From 796bf6d1b58d675b04198e536bae62552b16da75 Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Sat, 16 Nov 2019 23:33:31 +0200 > > Subject: [PATCH] services: sysctl: Make service one-shot. > > > > * gnu/services/sysctl.scm (sysctl-shepherd-service): Adjust shepherd > > service to use the 'one-shot?' keyword. Remove 'stop' command. Remove > > 'respawn' option. > > --- > > gnu/services/sysctl.scm | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/gnu/services/sysctl.scm b/gnu/services/sysctl.scm > > index 5e9e6f0661..2110b80395 100644 > > --- a/gnu/services/sysctl.scm > > +++ b/gnu/services/sysctl.scm > > @@ -58,9 +58,8 @@ > > (documentation "Configure kernel parameters at boot.") > > (provision '(sysctl)) > > (start #~(lambda _ > > - (zero? (system* #$sysctl "--load" #$sysctl.conf)))) > > - (stop #~(const #t)) > > - (respawn? #f)))))) > > + (invoke #$sysctl "--load" #$sysctl.conf))) > > + (one-shot? #t)))))) >=20 > Perhaps we=E2=80=99d rather keep the (zero? (system* =E2=80=A6)) idiom he= re, so that > =E2=80=98herd start=E2=80=99 gracefully reports failure of =E2=80=98sysct= l=E2=80=99. I didn't think that'd be a problem. >=20 > Apart from that, it=E2=80=99s all good to me! :-) >=20 > Ludo=E2=80=99. Ok, patch pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --K5z5w9fsx/Hrkgg3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3VkwQACgkQQarn3Mo9 g1GPIw//b5Lhv7Jq11Dh7hdtYPwkjY79ykZQZwwjBbr4NP8ITd1D+DpAyZnulBjC o+6kS5Se7iJatQiF/ZTfuk1uITGxF9jFJem8MjdLHo7+yZu9QyKqSvljWzhpb5wE Xt1GW7TLf9T63do1PmHHxdK+c5QhN4UJdLthjNv2GGGS4naBtkld8p7cyGyH1h3v mE2FaI/4lS//27L5ESABHO3qMS3+lKAFgfM9fP1JA2k9AhxU+YGs/7cTJAVzwaiU NteraPLQ9fCiKLU0V5ypmShaH/x7Ta/DjpFUFMFolkLEGFKuc8oBOZu40KXAJD7g yyOaLsWnqTeTQ0Qtfk/wHnvlSctT7uRd6PFxZmsPm0QjdgcSJozYYvMGRVhGH4cc zfo1eYsIAPbIuOZ0ooYfBAZN/CljVnpzk1r/GMPYXy11212cHWOgYgUYZZoG5XFu yOgWWH6zM6yDGF7JHpShyh918F08p3COi+Ln/rR1bQDZAIoo+ogm2nx3Vur6tPTm dF412IyB4InhoDg4qkw0T1P0sRzRJ/P6UP4AlufgtHK3N2aNxIiJor2p3B0hha/v bReiMYVNaCUlAqgpAAJhc8jWaxKkdgy23N4B/z0H73U5cciR288lidyjuqAhqi4V 0LpdPfw48/HgcNKh77s9wl0Zg3kobOUPxIxKDV5Vzu2feBMFbUs= =CIe9 -----END PGP SIGNATURE----- --K5z5w9fsx/Hrkgg3--