unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: 38240@debbugs.gnu.org
Subject: [bug#38240] [PATCH v2] services: sysctl: Make service one-shot.
Date: Mon, 18 Nov 2019 10:21:11 +0200	[thread overview]
Message-ID: <20191118082111.GF15074@E5400> (raw)
In-Reply-To: <20191116214206.20590-1-efraim@flashner.co.il>


[-- Attachment #1.1: Type: text/plain, Size: 376 bytes --]

After looking at the 'user-homes' commit to switch that to a one-shot
service, I've made a small change to the patch. (Namely, I removed the
'stop' command).


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #1.2: 0001-services-sysctl-Make-service-one-shot.patch --]
[-- Type: text/plain, Size: 1052 bytes --]

From fa6ed7c614d2b3e42fbcb44878b69ebda37f23e7 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sat, 16 Nov 2019 23:33:31 +0200
Subject: [PATCH] services: sysctl: Make service one-shot.

* gnu/services/sysctl.scm (sysctl-shepherd-service): Adjust shepherd
service to use '--one-shot' flag. Remove 'stop' command. Remove
'respawn' option.
---
 gnu/services/sysctl.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/services/sysctl.scm b/gnu/services/sysctl.scm
index 5e9e6f0661..e59e345189 100644
--- a/gnu/services/sysctl.scm
+++ b/gnu/services/sysctl.scm
@@ -58,9 +58,7 @@
         (documentation "Configure kernel parameters at boot.")
         (provision '(sysctl))
         (start #~(lambda _
-                   (zero? (system* #$sysctl "--load" #$sysctl.conf))))
-        (stop #~(const #t))
-        (respawn? #f))))))
+                   (invoke #$sysctl "--load" #$sysctl.conf "--one-shot"))))))))
 
 (define sysctl-service-type
   (service-type
-- 
2.24.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-11-18  8:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 21:42 [bug#38240] [PATCH] services: sysctl: Make service one-shot Efraim Flashner
2019-11-18  8:21 ` Efraim Flashner [this message]
2019-11-19  9:44   ` [bug#38240] [PATCH v2] " Ludovic Courtès
2019-11-19  9:57     ` Efraim Flashner
2019-11-19 10:00     ` [bug#38240] [PATCH v3] " Efraim Flashner
2019-11-20 14:10       ` Ludovic Courtès
2019-11-20 19:24         ` bug#38240: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118082111.GF15074@E5400 \
    --to=efraim@flashner.co.il \
    --cc=38240@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).