unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12.
@ 2019-11-05 21:00 Hartmut Goebel
  2019-11-06  7:09 ` Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: Hartmut Goebel @ 2019-11-05 21:00 UTC (permalink / raw)
  To: 38073

Build using gnu++11 standard.

* gnu/packages/qt.scm(grantlee)[argument]<configure-flags>: New
  element.
---
 gnu/packages/qt.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 8928c1ddd4..0ef879678f 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -100,7 +100,8 @@
        ("qtscript" ,qtscript)))
     (build-system cmake-build-system)
     (arguments
-     `(#:phases
+     `(#:configure-flags '("-DCMAKE_CXX_STANDARD=11")
+       #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'delete-broken-tests
            (lambda _
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12.
  2019-11-05 21:00 [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12 Hartmut Goebel
@ 2019-11-06  7:09 ` Efraim Flashner
  2019-11-06  9:31   ` bug#38073: " Hartmut Goebel
  0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2019-11-06  7:09 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 38073

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Looks good to me. Assuming it builds go ahead and push it to master or
staging, whichever is better for it.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#38073: [PATCH] gnu: grantlee: Fix build for Qt 5.12.
  2019-11-06  7:09 ` Efraim Flashner
@ 2019-11-06  9:31   ` Hartmut Goebel
  0 siblings, 0 replies; 3+ messages in thread
From: Hartmut Goebel @ 2019-11-06  9:31 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 38073-close

Am 06.11.19 um 08:09 schrieb Efraim Flashner:
> Looks good to me. Assuming it builds go ahead and push it to master or
> staging, whichever is better for it.
>
>
Pushed to staging, as Qt 5.12 is not yet in master.

ea57bb893eeb7008064d2f511dede616d4bdcbd1

Thanks for the review.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-06  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 21:00 [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12 Hartmut Goebel
2019-11-06  7:09 ` Efraim Flashner
2019-11-06  9:31   ` bug#38073: " Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).