From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:55403)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQyIi-00036M-Kr
 for guix-patches@gnu.org; Sat, 02 Nov 2019 14:39:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQyIg-00085k-NH
 for guix-patches@gnu.org; Sat, 02 Nov 2019 14:39:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52512)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iQyIg-00085O-9d
 for guix-patches@gnu.org; Sat, 02 Nov 2019 14:39:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iQyIf-0003ge-Rl
 for guix-patches@gnu.org; Sat, 02 Nov 2019 14:39:02 -0400
Subject: [bug#38030] [PATCH 13/13] gnu: kpmcore: Update to 4.0.1
Resent-Message-ID: <handler.38030.B38030.157271991714130@debbugs.gnu.org>
Date: Sat, 2 Nov 2019 19:38:25 +0100
From: Miguel Arruga Vivas <rosen644835@gmail.com>
Message-ID: <20191102193825.0220ad25@gmail.com>
In-Reply-To: <20191102090950.18043-13-h.goebel@crazy-compilers.com>
References: <20191102090950.18043-1-h.goebel@crazy-compilers.com>
 <20191102090950.18043-13-h.goebel@crazy-compilers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 38030@debbugs.gnu.org

Hi Hartmut,

Just a couple of comments (although I'm not an official reviewer) about
this patch.

Hartmut Goebel <h.goebel@crazy-compilers.com> wrote:
> Also move to kde.scm, since it is a frameworks part.
>=20
> * gnu/packages/kde-frameworks.scm(kpmcore): Move from here =E2=80=A6
> * gnu/packages/kde.scm(kpmcore): =E2=80=A6 to here, update to 4.0.1;
> [inputs]: Add qttools; [native-inputs]: Add dbus; [arguments]: New
> element.

You moved kholidays to kde-frameworks.scm as it is now part of
the framework, but this comment seems to suggest that the framework
parts are located in kde.scm.  Is there any reason to not keep it there?

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             ;(setenv "HOME" (getcwd))
> +             ;(setenv "TMPDIR" (getcwd))
> +             ;(setenv "QT_QPA_PLATFORM" "offscreen")
> +             (invoke "dbus-launch" "ctest" "."))))))

That commented code seems a left over from previous tests.  Perhaps
it should be removed, perhaps a comment makes sense there. :)

Best regards,
Miguel