From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41254) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQY6p-0007j8-Qd for guix-patches@gnu.org; Fri, 01 Nov 2019 10:41:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQY6o-0000SH-Q3 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQY6o-0000Ru-Mb for guix-patches@gnu.org; Fri, 01 Nov 2019 10:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQY6o-0004t2-G3 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:41:02 -0400 Subject: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) Resent-Message-ID: Date: Fri, 1 Nov 2019 16:39:54 +0200 From: Efraim Flashner Message-ID: <20191101143954.GK20762@E5400> References: <20191024192056.5428-1-h.goebel@crazy-compilers.com> <20191025103449.GI15460@E5400> <20191025104300.GK15460@E5400> <87ftjgldd4.fsf@gnu.org> <3917a043-2800-a2e7-781c-48d23f0aed40@crazy-compilers.com> <87imo3euqw.fsf@gnu.org> <531d87da-8ad9-e6e9-cfce-9d447e9b5233@crazy-compilers.com> <87eeyrd6q7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EVcIhgQsEzAXu06J" Content-Disposition: inline In-Reply-To: <87eeyrd6q7.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Hartmut Goebel , 37908@debbugs.gnu.org --EVcIhgQsEzAXu06J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 01, 2019 at 03:14:08PM +0100, Ludovic Court=C3=A8s wrote: > Hi Hartmut, >=20 > Hartmut Goebel skribis: >=20 > > From: Hartmut Goebel > > Date: Thu, 24 Oct 2019 20:28:26 +0200 > > Subject: [Patch v2 2/2] gnu: Deprecate monolithic qt5. > > > > This package was not used anywhere but as a based for qt-4. > > > > * gnu/packages/qt.scm (qt-4): Copy all relevant package definition > > parts from 'qt'. > > (qt): Define as a deprecated alias for 'qtbase`. >=20 > Please ensure that =E2=80=9Cguix build qt@4 -nd=E2=80=9D returns the same= derivation > before and after the change. >=20 > > +(define-deprecated qt qtbase qtbase) >=20 > Perhaps add a comment above saying that =E2=80=98qt=E2=80=99 used to refe= r to the > monolithic Qt 5.x package? >=20 > Otherwise LGTM! Efraim, can you say if this is fine with you? > When Efraim agrees to the change, I guess you can go ahead. >=20 I didn't apply it locally, I can do it in about 36 hours, but it looks good. IIRC we have qt4 inheriting from qt5, and qtbase was its own definition so nothing should change on that side. LGTM --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --EVcIhgQsEzAXu06J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl28Q7gACgkQQarn3Mo9 g1FuVBAAnrh3XsOC2vLp5or97QeUZXXgj165fEfCz8NMuOOKpmvInUj8fjTJmefL xoo1QBKM0LSnyWFs1xliJJ6ABTrD45qVxQtQ9PU5MjmW1T4FFK511MEGGf/blEfN uWdtw5IJgDJUCpYCqyG8ypds/WdjTj6fRd1fbVu4oNVO9SIPVI3X2lS4i9Wjcw9Y z4Gr18xl1/lxO2s4BiFsiKMx7q1B/xDpOBiYhETAgQlisoIdfy9QBPJyWHpyBWUe WHMY82QIZB568dElX4Q6uAzHGt9nGnyB7eIE5gjK2ybVLHxtYwbeyTuBm6vJpCRy XYl1DKiSvJ+lgXRC1Glr8tWRVaI100gYSOouu7zriHE7JVHDzL7n1iuvr73p07Im exPwxYbaQdJ1hLzJnxSykQKSiZ4NddR+cjAuo/N9zkAtVOYPOzSTO603CdzAHilA 6W955d/Cl2Tts7sErUWrtJKoQeyqRDz6xfM5KySkNVSEBx8zLmHifSqikckt2Pcm QHaDLVNwd4cz/xTBh4NENnfi3QT++rDMwNbXagYsnjbYVhduQfEW+GpYC0KMbzC9 aXnQnAqZEW10cqnehVb8ex7DscJzBTzTom2jsL9gDz9bXXbNLnnUOX+CZ9QocHwZ P16QvrnyeIp7nvHe9p11+Oa17mhSg9mG/U/DTye8pRBJ8HzJxRQ= =qGbE -----END PGP SIGNATURE----- --EVcIhgQsEzAXu06J--