From: Arne Babenhauserheide <arne_bab@web.de>
To: 36630@debbugs.gnu.org
Cc: Arne Babenhauserheide <arne_bab@web.de>
Subject: [bug#36630] [PATCH] use two threads to build man-pages and secure output msgs with mutex
Date: Sun, 27 Oct 2019 17:27:57 +0100 [thread overview]
Message-ID: <20191027162757.32295-1-arne_bab@web.de> (raw)
In-Reply-To: <20190712214245.23857-1-arne_bab@web.de>
---
guix/profiles.scm | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/guix/profiles.scm b/guix/profiles.scm
index a0ae9a4c7e..9d2133df2d 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -1315,11 +1315,18 @@ the entries in MANIFEST."
(ice-9 threads)
(srfi srfi-1)
(srfi srfi-19))
+ ;; ensure conflict free user-output
+ (define status-output-mutex (make-mutex))
+
+ (define (status-message msg)
+ (lock-mutex status-output-mutex)
+ (display msg)
+ (unlock-mutex status-output-mutex))
(define (compute-entry directory count total)
- (format #t "\r[~3d/~3d] building list of \
+ (status-message (format #f "\r[~3d/~3d] building list of \
man-db entries..."
- count total)
+ count total))
(force-output)
(let ((man (string-append directory
"/share/man")))
@@ -1332,7 +1339,9 @@ man-db entries..."
;; decompression), so report progress as we traverse INPUTS.
(let* ((inputs '#$(manifest-inputs manifest))
(total (length inputs)))
- (apply append (par-map compute-entry
+ ;; experimenting shows that two threads suffice to remove most
+ ;; waiting
+ (apply append (n-par-map 2 compute-entry
inputs
(iota total 1)
(make-list total total)))))
--
2.23.0
prev parent reply other threads:[~2019-10-27 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 21:42 [bug#36630] [PATCH] guix: parallelize building the manual-database Arne Babenhauserheide
2019-07-15 16:12 ` Ludovic Courtès
2019-07-15 23:32 ` Arne Babenhauserheide
2019-07-16 21:14 ` Ludovic Courtès
2019-07-17 22:06 ` Arne Babenhauserheide
2019-07-18 8:55 ` Ludovic Courtès
2019-07-18 8:57 ` Ludovic Courtès
2019-07-18 10:59 ` Arne Babenhauserheide
2019-07-18 13:46 ` Ludovic Courtès
2019-07-18 20:03 ` Arne Babenhauserheide
2019-10-23 20:01 ` Arne Babenhauserheide
2020-03-31 13:02 ` bug#36630: " Ludovic Courtès
2019-10-23 19:59 ` [bug#36630] [PATCH] use two threads to build man-pages and secure output msgs with mutex Arne Babenhauserheide
2019-10-27 16:27 ` Arne Babenhauserheide [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027162757.32295-1-arne_bab@web.de \
--to=arne_bab@web.de \
--cc=36630@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).