From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58400)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iOOga-0001Op-Fc
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:13:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iOOgY-0004CJ-Gw
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:13:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60809)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iOOgY-0004CC-Dd
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iOOgY-0001pf-6u
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:13:02 -0400
Subject: [bug#37923] [PATCH 1/2] gnu: profanity: Add configure flags and
 inputs for better defaults.
Resent-Message-ID: <handler.37923.B.15721063817036@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58365)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tanguy@bioneland.org>) id 1iOOgO-0000PJ-CJ
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:12:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <tanguy@bioneland.org>) id 1iOOgN-00044X-9v
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:12:52 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52479)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <tanguy@bioneland.org>)
 id 1iOOgN-0003yb-3P
 for guix-patches@gnu.org; Sat, 26 Oct 2019 12:12:51 -0400
Date: Sat, 26 Oct 2019 18:12:46 +0200
From: Tanguy Le Carrour <tanguy@bioneland.org>
Message-ID: <20191026161246.bi6kxcrc6zkdqns5@melmoth>
References: <20191025151711.aoqcwzuz7vwcgdbm@rafflesia>
 <20191025152040.25196-1-tanguy@bioneland.org>
 <87h83wu49h.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87h83wu49h.fsf@gmail.com>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 37923@debbugs.gnu.org

Hi Mathieu,


Le 10/25, Mathieu Othacehe a écrit :
> Much better with git send-email ;) A few remarks below:
> 
> > +     `(#:configure-flags
>          ^
> It can be ' because there are no unquoting in the following list.

Done!


> > +             "--enable-icon"
>                               ^
> I think it is --enable-icons but that triggers missing inputs. You can
> have a look to nix recipe if needed.

Outch! Sorry for that! Actually when I added it I thought "if I don't
spell it properly, configure will fail, won't it?"… obviously I was
wrong! ^_^'


v2 is following.

I also added "--enable-c-plugins" and "--enable-otr" with the comment
from Nix expression ("Enable feature flags, so that build fail if libs
are missing") in the commit message. And I added "--enable-pgp" in
a separate commit… but I guess you'll squash everything together, right?

I tried to add "--enable-python-plugins" and "python" as a native input,
but it did not work! So, for now, I left it out.

Thanks again for reviewing!

-- 
Tanguy