unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
@ 2019-10-25  9:35 Guillaume Le Vaillant
  2019-10-25  9:35 ` Guillaume Le Vaillant
  2019-10-25 10:41 ` Efraim Flashner
  0 siblings, 2 replies; 7+ messages in thread
From: Guillaume Le Vaillant @ 2019-10-25  9:35 UTC (permalink / raw)
  To: 37919

Some icons are not showing properly in the application because it wants
PyQt 5.12.* and Guix only has PyQt 5.11.3 so far. The current packaged version
of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
why. Anyway, it doesn't prevent the application from working (sending and
receiving transactions, etc).

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-10-25  9:35 [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10 Guillaume Le Vaillant
@ 2019-10-25  9:35 ` Guillaume Le Vaillant
  2019-10-25 10:41 ` Efraim Flashner
  1 sibling, 0 replies; 7+ messages in thread
From: Guillaume Le Vaillant @ 2019-10-25  9:35 UTC (permalink / raw)
  To: 37919; +Cc: Guillaume Le Vaillant

* gnu/packages/finance.scm (electron-cash): Update to 4.0.10.
  [inputs]: Add python-dateutil.
  [documentation]: Keep line width below 80.
---
 gnu/packages/finance.scm | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 960e3adeb3..1f2d9ada04 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -76,6 +76,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
+  #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages upnp)
   #:use-module (gnu packages version-control)
@@ -413,7 +414,7 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
   (package
     (inherit electrum)
     (name "electron-cash")
-    (version "4.0.7")
+    (version "4.0.10")
     (source
      (origin
        (method url-fetch)
@@ -424,20 +425,24 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
                            ".tar.gz"))
        (sha256
         (base32
-         "0xswmr68cm1c77lzisi3z812jzqczm9dfrshfhdq42zz5kaz4gnn"))
+         "1rcywlma6hk52ymisx536jvkdwa73rhn1jxhsbs4wbvajl90w9s8"))
        (modules '((guix build utils)))
        (snippet
         '(begin
            ;; Delete the bundled dependencies.
            (delete-file-recursively "packages")
            #t))))
+    (inputs
+     `(("python-dateutil" ,python-dateutil)
+       ,@(package-inputs electrum)))
     (home-page "https://electroncash.org/")
     (synopsis "Bitcoin Cash wallet")
     (description
-     "Electroncash is a lightweight Bitcoin Cash client, based on a client-server
-protocol.  It supports Simple Payment Verification (SPV) and deterministic key
-generation from a seed.  Your secret keys are encrypted and are never sent to
-other machines/servers.  Electroncash does not download the Bitcoin Cash blockchain.")
+     "Electroncash is a lightweight Bitcoin Cash client, based on
+a client-server protocol.  It supports Simple Payment Verification (SPV) and
+deterministic key generation from a seed.  Your secret keys are encrypted and
+are never sent to other machines/servers.  Electroncash does not download the
+Bitcoin Cash blockchain.")
     (license license:expat)))
 
 (define-public monero
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-10-25  9:35 [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10 Guillaume Le Vaillant
  2019-10-25  9:35 ` Guillaume Le Vaillant
@ 2019-10-25 10:41 ` Efraim Flashner
  2019-10-25 11:40   ` Guillaume Le Vaillant
  1 sibling, 1 reply; 7+ messages in thread
From: Efraim Flashner @ 2019-10-25 10:41 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: 37919

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Fri, Oct 25, 2019 at 11:35:55AM +0200, Guillaume Le Vaillant wrote:
> Some icons are not showing properly in the application because it wants
> PyQt 5.12.* and Guix only has PyQt 5.11.3 so far.

qt-5.12 and pyqt-5.12 are coming soon™ with the staging branch.

>                                                   The current packaged version
> of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
> why. Anyway, it doesn't prevent the application from working (sending and
> receiving transactions, etc).
> 

If it already has the problem then I don't see it being a blocker. Are
you sure the new version doesn't want qt-5.13+? We haven't started with
that yet.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-10-25 10:41 ` Efraim Flashner
@ 2019-10-25 11:40   ` Guillaume Le Vaillant
  2019-11-26 10:48     ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Guillaume Le Vaillant @ 2019-10-25 11:40 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 37919


Efraim Flashner skribis:

> If it already has the problem then I don't see it being a blocker. Are
> you sure the new version doesn't want qt-5.13+? We haven't started with
> that yet.

Yes, when the program starts it shows the following warning:

--8<---------------cut here---------------start------------->8---
Electron Cash on Linux requires PyQt5 5.12+.

You have version 5.11.3 installed.

Please upgrade otherwise you may experience font rendering issues
with emojis and other unicode characters used by Electron Cash.
--8<---------------cut here---------------end--------------->8---

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-10-25 11:40   ` Guillaume Le Vaillant
@ 2019-11-26 10:48     ` Ludovic Courtès
  2019-11-27 10:20       ` Guillaume Le Vaillant
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2019-11-26 10:48 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: Efraim Flashner, 37919

Hello!

What’s the conclusion regarding this upgrade?  Should we apply it or
not?  :-)

  https://issues.guix.gnu.org/issue/37919

TIA,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-11-26 10:48     ` Ludovic Courtès
@ 2019-11-27 10:20       ` Guillaume Le Vaillant
  2019-11-28  8:30         ` bug#37919: " Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Guillaume Le Vaillant @ 2019-11-27 10:20 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Efraim Flashner, 37919


Ludovic Courtès skribis:

> Hello!
>
> What’s the conclusion regarding this upgrade?  Should we apply it or
> not?  :-)
>
>   https://issues.guix.gnu.org/issue/37919
>
> TIA,
> Ludo’.

As there's been another release of electron-cash since, I think we could
close this issue, wait for the staging branch which has Qt 5.12 to be
merged, and make a new upgrade patch for electron-cash then.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#37919: [PATCH] gnu: electron-cash: Update to 4.0.10.
  2019-11-27 10:20       ` Guillaume Le Vaillant
@ 2019-11-28  8:30         ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2019-11-28  8:30 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: Efraim Flashner, 37919-done

Hi Guillaume,

Guillaume Le Vaillant <glv@posteo.net> skribis:

> Ludovic Courtès skribis:
>
>> Hello!
>>
>> What’s the conclusion regarding this upgrade?  Should we apply it or
>> not?  :-)
>>
>>   https://issues.guix.gnu.org/issue/37919
>>
>> TIA,
>> Ludo’.
>
> As there's been another release of electron-cash since, I think we could
> close this issue, wait for the staging branch which has Qt 5.12 to be
> merged, and make a new upgrade patch for electron-cash then.

Sounds good, closing it!

I think we’ll all have to take care of ‘staging’, it needs more
attention.  :-)

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-11-28  8:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-25  9:35 [bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10 Guillaume Le Vaillant
2019-10-25  9:35 ` Guillaume Le Vaillant
2019-10-25 10:41 ` Efraim Flashner
2019-10-25 11:40   ` Guillaume Le Vaillant
2019-11-26 10:48     ` Ludovic Courtès
2019-11-27 10:20       ` Guillaume Le Vaillant
2019-11-28  8:30         ` bug#37919: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).