From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 37788@debbugs.gnu.org
Subject: [bug#37788] [PATCH] gnu: Add minisign.
Date: Fri, 18 Oct 2019 12:03:10 +0200 [thread overview]
Message-ID: <20191018100310.odkacqejqpes7f7i@rafflesia> (raw)
In-Reply-To: <20191017080233.dcsjsyh5ui6x67kj@rafflesia>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 713 bytes --]
Hello Mathieu!
Thanks for reviewing!
From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Please pass --subject-prefix="PATCH v2" to git format-patch so that it
> is easier to identify patch revisions.
I'll try to keep that it mind for next time!
>> + ; No test suite
>You can put it on the same line as the one below.
>> + `(#:tests? #f))
I did… then ran etc/indent-code.el which pushed the comment far away on
the right. It looked weird, so I moved it above. Next time I'll leave it
where the indent-code script puts it.
>You also did forget to add the Copyright on top.
*Oups*… thanks for noticing!
>Otherwise seems fine :). I fixed the points above and pushed it.
Thanks!
--
Tanguy
prev parent reply other threads:[~2019-10-18 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 8:02 [bug#37788] [PATCH] gnu: Add minisign Tanguy Le Carrour
2019-10-17 8:09 ` Tanguy Le Carrour
2019-10-17 15:32 ` Mathieu Othacehe
2019-10-18 10:03 ` Tanguy Le Carrour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018100310.odkacqejqpes7f7i@rafflesia \
--to=tanguy@bioneland.org \
--cc=37788@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).