unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37788] [PATCH] gnu: Add minisign.
@ 2019-10-17  8:02 Tanguy Le Carrour
  2019-10-17  8:09 ` Tanguy Le Carrour
  2019-10-18 10:03 ` Tanguy Le Carrour
  0 siblings, 2 replies; 4+ messages in thread
From: Tanguy Le Carrour @ 2019-10-17  8:02 UTC (permalink / raw)
  To: 37788

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: Type: text/plain, Size: 2071 bytes --]

From 7d5c08fd00e9cd5d883fc939187ce6fc6e8c45f7 Mon Sep 17 00:00:00 2001
From: Tanguy Le Carrour <tanguy@bioneland.org>
Date: Thu, 17 Oct 2019 09:57:28 +0200
Subject: [PATCH] gnu: Add minisign.

* gnu/packages/crypto.scm (minisign): New public variable.
---
 gnu/packages/crypto.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 9592d18011..baf7c81a6a 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -974,3 +974,37 @@ pre-shared keys out of band.  It is designed to handle large amounts of data
 quickly by using all your CPU cores and hardware acceleration.")
     (home-page "https://github.com/vstakhov/hpenc")
     (license license:bsd-3)))
+
+(define-public minisign
+  (package
+    (name "minisign")
+    (version "0.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "https://github.com/jedisct1/minisign/releases/download/"
+                       version "/minisign-" version ".tar.gz"))
+       (sha256
+        (base32
+         "10hhgwxf9rcdlr00shrkcyxndrc22dh5lj8k5z27xg3nc0jba3hk"))))
+    (build-system cmake-build-system)
+    (arguments
+     ; No test suite
+     `(#:tests? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libsodium" ,libsodium)))
+    (home-page "https://jedisct1.github.io/minisign")
+    (synopsis "Tool to sign files and verify signatures")
+    (description
+     "Minisign is a dead simple tool to sign files and verify signatures.  It is
+portable, lightweight, and uses the highly secure Ed25519 public-key signature
+system.  Signature written by minisign can be verified using OpenBSD's
+signify tool: public key files and signature files are compatible.  However,
+minisign uses a slightly different format to store secret keys.  Minisign
+signatures include trusted comments in addition to untrusted comments.
+Trusted comments are signed, thus verified, before being displayed.")
+    (license license:isc)))
+
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#37788] [PATCH] gnu: Add minisign.
  2019-10-17  8:02 [bug#37788] [PATCH] gnu: Add minisign Tanguy Le Carrour
@ 2019-10-17  8:09 ` Tanguy Le Carrour
  2019-10-17 15:32   ` Mathieu Othacehe
  2019-10-18 10:03 ` Tanguy Le Carrour
  1 sibling, 1 reply; 4+ messages in thread
From: Tanguy Le Carrour @ 2019-10-17  8:09 UTC (permalink / raw)
  To: 37788

[-- Attachment #1: Type: text/plain, Size: 30 bytes --]

Remove new blank line at EOF.

[-- Attachment #2: Type: text/plain, Size: 2068 bytes --]

From 467e7d9566cc655c4ea226769b76c8d803ecb4d4 Mon Sep 17 00:00:00 2001
From: Tanguy Le Carrour <tanguy@bioneland.org>
Date: Thu, 17 Oct 2019 09:57:28 +0200
Subject: [PATCH] gnu: Add minisign.

* gnu/packages/crypto.scm (minisign): New public variable.
---
 gnu/packages/crypto.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 9592d18011..9ab15a6395 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -974,3 +974,36 @@ pre-shared keys out of band.  It is designed to handle large amounts of data
 quickly by using all your CPU cores and hardware acceleration.")
     (home-page "https://github.com/vstakhov/hpenc")
     (license license:bsd-3)))
+
+(define-public minisign
+  (package
+    (name "minisign")
+    (version "0.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "https://github.com/jedisct1/minisign/releases/download/"
+                       version "/minisign-" version ".tar.gz"))
+       (sha256
+        (base32
+         "10hhgwxf9rcdlr00shrkcyxndrc22dh5lj8k5z27xg3nc0jba3hk"))))
+    (build-system cmake-build-system)
+    (arguments
+     ; No test suite
+     `(#:tests? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libsodium" ,libsodium)))
+    (home-page "https://jedisct1.github.io/minisign")
+    (synopsis "Tool to sign files and verify signatures")
+    (description
+     "Minisign is a dead simple tool to sign files and verify signatures.  It is
+portable, lightweight, and uses the highly secure Ed25519 public-key signature
+system.  Signature written by minisign can be verified using OpenBSD's
+signify tool: public key files and signature files are compatible.  However,
+minisign uses a slightly different format to store secret keys.  Minisign
+signatures include trusted comments in addition to untrusted comments.
+Trusted comments are signed, thus verified, before being displayed.")
+    (license license:isc)))
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#37788] [PATCH] gnu: Add minisign.
  2019-10-17  8:09 ` Tanguy Le Carrour
@ 2019-10-17 15:32   ` Mathieu Othacehe
  0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2019-10-17 15:32 UTC (permalink / raw)
  To: 37788


Hello Tanguy,

> Remove new blank line at EOF.

Please pass --subject-prefix="PATCH v2" to git format-patch so that it
is easier to identify patch revisions.

> +     ; No test suite

You can put it on the same line as the one below.

> +     `(#:tests? #f))

You also did forget to add the Copyright on top.

Otherwise seems fine :). I fixed the points above and pushed it.

Mathieu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#37788] [PATCH] gnu: Add minisign.
  2019-10-17  8:02 [bug#37788] [PATCH] gnu: Add minisign Tanguy Le Carrour
  2019-10-17  8:09 ` Tanguy Le Carrour
@ 2019-10-18 10:03 ` Tanguy Le Carrour
  1 sibling, 0 replies; 4+ messages in thread
From: Tanguy Le Carrour @ 2019-10-18 10:03 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 37788

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 713 bytes --]

Hello Mathieu!

Thanks for reviewing!

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Please pass --subject-prefix="PATCH v2" to git format-patch so that it
> is easier to identify patch revisions.

I'll try to keep that it mind for next time!


>> +     ; No test suite
>You can put it on the same line as the one below.
>> +     `(#:tests? #f))

I did… then ran etc/indent-code.el which pushed the comment far away on
the right. It looked weird, so I moved it above. Next time I'll leave it
where the indent-code script puts it.


>You also did forget to add the Copyright on top.

*Oups*… thanks for noticing!


>Otherwise seems fine :). I fixed the points above and pushed it.

Thanks!


-- 
Tanguy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-18 10:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17  8:02 [bug#37788] [PATCH] gnu: Add minisign Tanguy Le Carrour
2019-10-17  8:09 ` Tanguy Le Carrour
2019-10-17 15:32   ` Mathieu Othacehe
2019-10-18 10:03 ` Tanguy Le Carrour

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).