From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43787) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJuUV-00059R-Jh for guix-patches@gnu.org; Mon, 14 Oct 2019 03:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJuUU-0002Qp-BN for guix-patches@gnu.org; Mon, 14 Oct 2019 03:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJuUU-0002Qj-7L for guix-patches@gnu.org; Mon, 14 Oct 2019 03:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJuUT-0004Fy-SB for guix-patches@gnu.org; Mon, 14 Oct 2019 03:10:01 -0400 Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time. Resent-Message-ID: Date: Mon, 14 Oct 2019 09:09:30 +0200 From: Tanguy Le Carrour Message-ID: <20191014070930.b2dbefwyiegup2q5@rafflesia> References: <20191003121316.irq3vdmu4ov6dygb@rafflesia> <20191004072040.fpwcb2lmeih2mvsv@rafflesia> <87eezt3q5r.fsf@gmail.com> <871rvg8fss.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <871rvg8fss.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37598@debbugs.gnu.org, Mathieu Othacehe Hi Ludovic, Hi Mathieu! Le 10/14, Ludovic Courtès a écrit : > Did you have a chance to look into Mathieu’s suggestions (below)? No!… because I don't get notifications when someone sends a comment on a bug I opened! :-( I have to go and check the 2 others I opened, I guess! I hope I didn't seem to give up on them! > Mathieu Othacehe skribis: > > Hello Tanguy, Sorry for not answering! And thanks for the time you spent into reviewing my patches! > > Thanks for your patches. A few remarks (more details at > > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html): > > > >> Subject: [PATCH 1/4] gnu: Add python-jinja2-time. > > > > You need to add a commit message, compliant with ChangeLog format. You > > can find examples in commit history. I have to confess that I am… a minimalist! :-) I thought that `gnu: Add python-jinja2-time.` would be enough and I didn't have to go into more details about the "why"! Please believe me when I say that it was not out of laziness. I'll go dig into commit messages and see what I have to add. > >> + (description > >> + "Jinja2 Extension for Dates and Times") > > > > Description should follow the rules dictated at > > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions, > > most specifically "Descriptions should take between five and ten > > lines. Use full sentences, and avoid using acronyms without first > > introducing them". OK, this one was pure laziness! So far, I've never modified description/synopsis provided by `guix import`. I guess, now that I'm more comfortable with the process, I can focus more on "what" I am submitting and less on "how" I am submitting it! Thanks again guys for your time. I'll fix the patches and resubmit them as soon as I can! -- Tanguy