From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53496) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFk1f-0001az-FJ for guix-patches@gnu.org; Wed, 02 Oct 2019 15:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFk1e-0007bE-Ah for guix-patches@gnu.org; Wed, 02 Oct 2019 15:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57751) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFk1e-0007bA-7e for guix-patches@gnu.org; Wed, 02 Oct 2019 15:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFk1e-0008Uc-0m for guix-patches@gnu.org; Wed, 02 Oct 2019 15:11:02 -0400 Subject: [bug#37589] [PATCH] gnu: Add xfce-goodies Resent-Message-ID: Date: Wed, 2 Oct 2019 21:09:57 +0200 From: Danny Milosavljevic Message-ID: <20191002210957.0e8a21ce@scratchpost.org> In-Reply-To: <20191002182854.10913-1-grumbel@gmail.com> References: <20191002182854.10913-1-grumbel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/.RA6HkXKrdGyJcTNInxHFof"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ingo Ruhnke Cc: 37589@debbugs.gnu.org --Sig_/.RA6HkXKrdGyJcTNInxHFof Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Ingo, wow, cool! A few nitpicks below: > + (description "Equake is a panel plugin for the XFCE desktop > +environment. It is based on the GNOME applet of the same name and was > +ported to XFCE starting with v1.03. Equake monitors earthquakes and > +will display an update each time a new earthquake occurs.") Please use two spaces to separate sentences: "environment. It" ... > +2.4's (at least 2.4.20 compiled with CONFIG_BLK_STATS turned on, or Maybe @code{CONFIG_BLK_STATS}. > +possibly older kernel patched with \"Disk extended statistics\" in > +/proc/partitions),or with NetBSD, based on the dk_rbytes and db_wbytes Similar: @file{/proc/partitions}, @code{dk_rbytes} and @code{db_wbytes}. > +values provided by the hw.diskstats sysctl (see iostat for details).") Similar @code{hw.diskstats} > +(define-public xfce4-embed-plugin > + ("gtk+-2" ,gtk+-2))) What's the deal with sometimes requiring gtk 2 and sometimes gtk 3? > +multi-mailbox mail watcher. Currently, the protocols supported are: Please use @itemize for the unordered list. > +1) System-defined directories (home folder, trash, desktop, file system) Please use @enumerate for ordered lists > + > +2) Removable media (using thunar-vfs) [...] If possible, please make one commit per package added. It's easier for peo= ple auditing the stuff in the commit log later. --Sig_/.RA6HkXKrdGyJcTNInxHFof Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl2U9gUACgkQ5xo1VCww uqVbuQf/S8Lo8Kaq4NgYE1IOSd70NSU/EDCXV+3WjQ+3Sv8oKC6xxStDSQNFv3sP qCKEKUw05AaAEv3UvsVxDVO25/eKsE4PDH3+A1DOhAOX9/rqTBlJwpFYYi6DVxmO OJsxGt+C2WeT6QKmnDaHpwB5xFfQWgJu1EIH+DPWPNkVn/ScdCoaNe0/jsw70BzN MrmQpbkLYq1fxh0m7IIDOvfDYS5q+IvLafpeT91OjRzN1POogsPyPjG34NYXYbTu rrob6/R5JGP9nCEM/M9OqJM/HzlHd0L/56FHk/LbsvbwQxjb8aDwc7jsLHKGCKrh 23A+4hNVrzGTXALiQEZXWSGGIwStzg== =T1q6 -----END PGP SIGNATURE----- --Sig_/.RA6HkXKrdGyJcTNInxHFof--