From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46670) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFQff-0003DR-RV for guix-patches@gnu.org; Tue, 01 Oct 2019 18:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFQfe-0002nB-Qo for guix-patches@gnu.org; Tue, 01 Oct 2019 18:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFQfe-0002n3-OW for guix-patches@gnu.org; Tue, 01 Oct 2019 18:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFQfe-0000MV-Kv for guix-patches@gnu.org; Tue, 01 Oct 2019 18:31:02 -0400 Subject: [bug#37519] [PATCH v2 2/2] gnu: add iwd. Resent-Message-ID: Date: Wed, 2 Oct 2019 00:30:21 +0200 From: Danny Milosavljevic Message-ID: <20191002003021.3be21cfe@scratchpost.org> In-Reply-To: <87sgocuazs.fsf@gnu.org> References: <793d-5d921680-4d-485b8300@90758574> <87sgocuazs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/GkQLZ7r+i4HAT=.5ei102K2"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37519@debbugs.gnu.org, "brice@waegenei.re" , 37493@debbugs.gnu.org --Sig_/GkQLZ7r+i4HAT=.5ei102K2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, > > It was missing the kernel module pkcs8_key_parser, as explained in src/= pkcs8.conf. Since we can't load it at build time, I disabled the test. It's fine to do it like that in that case, but just some food for thought: We often disable tests in cases like that because writing system tests for = something like that is annoying if one has to do it manually. Would it be possible to discover packages which need those kinds of tests (= if necessary just specify an "argument" in the package record) and automati= cally create&run system tests for them? Guix would then run all the tests = in a qemu-system container. Something like $ make TESTS=3Dpackages check-system which would: * Traverse all the packages with (#:run-tests-as-system-tests? #t) * Automatically set up a system test to run the tests of all of these packa= ges. Basically we could just provide guix-daemon inside a qemu guest and b= uild the same derivation again in there, letting it load Linux kernel modul= es however it wants. Especially Linux kernel-requiring (or worse, -modifying) tests are otherwis= e impossible to do. Long term, I don't feel good excluding all those tests just because they ar= e low-level. Docs: >there is no automatic module loading for key type parsers Why not? Weird... there's require_module, was it not thought of--or is it = inapplicable somehow? --Sig_/GkQLZ7r+i4HAT=.5ei102K2 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl2T030ACgkQ5xo1VCww uqUm8Qf+OZGPRZaYeRzK9zxVzquiHkFwxlmhPa68IhMu6Nf6T0giI58/1mz7m9Ea BXA14sRkqSkpCpLUEqowbupcSE5yvA5wiVxHCHS2ZGvUH44Z9mR+dlNbcIT2sTiW +ha/vwffKL+6FtNpRwMxlNciR4YoJ7wQW8DA099Ibxqb0xeLOXbvnbmqJcqD7ZwL equEVMXpKuk+UoVOqd0K8vZIlyKWT4CkaEnR65pqtUlDUzPfEFKyPrqpA/jjHbEF n0C0x9NVqOfQAFk3Vgwma9C+Y3W7T8Wzw3puch5nwQ4D4HkL7ms+hfvR5M9azZKM WSQVbg16772TsvxOl7WDtMpr6FoQEg== =MILZ -----END PGP SIGNATURE----- --Sig_/GkQLZ7r+i4HAT=.5ei102K2--