unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: 37442@debbugs.gnu.org
Subject: [bug#37442] [PATCH] import/github: Check for more version prefixes
Date: Tue, 17 Sep 2019 21:59:15 +0300	[thread overview]
Message-ID: <20190917185915.GA6057@E5400> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

'guix refresh openjpeg'
gnu/packages/image.scm:762:13: openjpeg would be upgraded from 2.3.1 to ersion.2.1

I checked the git repository, there are a number of tags reading
'version.2.1' or similar. This allows for version tags 'version2.1' or
'version-2.1' or 'version.2.1' or 'version→2.1'. (still looking for a
repo to test the last one)

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #1.2: 0001-import-github-Check-for-more-version-prefixes.patch --]
[-- Type: text/plain, Size: 1575 bytes --]

From 1d32a908d3bdbec89420b638791960e7535a5e90 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 17 Sep 2019 21:50:36 +0300
Subject: [PATCH] import/github: Check for more version prefixes.

* guix/import/github.scm (latest-released-version): Allow the
version string to begin with the word 'version'.
---
 guix/import/github.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index 55ea00a111..df5f6ff32f 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2017, 2018, 2019 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2019 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2019 Efraim Flashner <efraim@flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -186,7 +187,12 @@ the package e.g. 'bedtools2'.  Return #f if there is no releases"
                        (substring tag 0 (+ name-length 1))))
         (substring tag (+ name-length 1)))
        ;; some tags start with a "v" e.g. "v0.25.0"
+       ;; or with the word "version" e.g. "version.2.1"
        ;; where some are just the version number
+       ((string-prefix? "version" tag)
+        (if (char-set-contains? char-set:digit (string-ref tag 7))
+            (substring tag 7)
+            (substring tag 8)))
        ((string-prefix? "v" tag)
         (substring tag 1))
        ;; Finally, reject tags that don't start with a digit:
-- 
2.23.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2019-09-17 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 18:59 Efraim Flashner [this message]
2019-09-19 19:50 ` [bug#37442] [PATCH] import/github: Check for more version prefixes Ludovic Courtès
2019-09-20  6:07   ` bug#37442: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917185915.GA6057@E5400 \
    --to=efraim@flashner.co.il \
    --cc=37442@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).