[bug#36410] [PATCH] gnu: Add screenfetch.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

I'm sorry, this one fell through the cracks and I forgot about it.

On Tue, Jul 02, 2019 at 12:07:31PM -0400, Jakob L. Kreuze wrote:
> Hi Efraim,
> 
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > If 'install-file' works here then the above 6 lines can be 2, something
> > like:
> > (install-file (string-append source "/screenfetch.1")
> >               (string-append %output "/man/man1/"))
> 
> That's certainly much clearer. Would it make sense to do the same for
> 'screenfetch-dev', renaming the file after copying it with
> 'install-file'? Or, should a '#:rename' keyword be added to
> 'install-file', perhaps? I don't know if it would be a useful pattern or
> not, but it's an easy addition and I'd be happy to submit a separate
> patch if there's any interest.
> 

I think since we want to rename it anyway I wouldn't bother with
'install-file' for screenfetch-dev.

> > you can use the patch-shebang function here, should help a bit.
> 
> Thanks, that seems to be just one of many hidden gems in '(guix build
> utils)'. I should really skim through that whole file at some point,
> these procedures would definitely make packaging much easier.
> 
> > Ideally these should wrap the binary rather than being propagated.
> 
> I'm a bit unsure as to what you mean. Should I patch the screenfetch
> script to use absolute paths for the binaries of these inputs? I.e.
> patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'?

I found an example of what I was thinking of in (gnu packages
dictionaries), with translate-shell. The function itself is called
'wrap-program'.

Can you send an updated patch?

thanks


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]