From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54413)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hzUu4-0007fX-LS
 for guix-patches@gnu.org; Sun, 18 Aug 2019 19:48:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hzUu3-0005c3-Lj
 for guix-patches@gnu.org; Sun, 18 Aug 2019 19:48:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:50121)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hzUu3-0005bx-G5
 for guix-patches@gnu.org; Sun, 18 Aug 2019 19:48:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hzUu3-0005fm-Aa
 for guix-patches@gnu.org; Sun, 18 Aug 2019 19:48:03 -0400
Subject: [bug#37048] [PATCH core-updates] gnu: qemu: Update to 4.1.0.
Resent-Message-ID: <handler.37048.B37048.156617205221765@debbugs.gnu.org>
Date: Sun, 18 Aug 2019 19:47:22 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20190818234722.GA25156@jasmine.lan>
References: <4be5db9d4f44a8463b23950676fab56f@mykolab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4be5db9d4f44a8463b23950676fab56f@mykolab.com>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rutger Helling <rhelling@mykolab.com>
Cc: 37048@debbugs.gnu.org

On Fri, Aug 16, 2019 at 06:27:42AM +0000, Rutger Helling wrote:
> Hey Guix,
> 
> here's a patch to update QEMU to 4.1.0.
> I'm sending it in for core-updates, since it only works there. It errors
> out with "fatal error: gnu/stubs-32.h: No such file or directory" on
> master (x86_64). Some change in GCC on core-updates seems to have solved
> this problem.

Thanks!

> From 170d67512d8f3412ee7f1b19b522fc2cb7cd6e29 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Thu, 15 Aug 2019 22:01:49 +0200
> Subject: [PATCH] gnu: qemu: Update to 4.1.0.
> 
> * gnu/local.mk: Remove qemu-CVE-2018-16872.patch and qemu-CVE-2019-6778.patch.
> * gnu/packages/patches/qemu-CVE-2018-16872.patch: Remove file.
> * gnu/packages/patches/qemu-CVE-2019-6778.patch: Remove file.
> * gnu/packages/virtualization.scm (qemu): Update to 4.1.0.
> [source]: Remove obsolete patches.
> [arguments]: Add phases 'disable-line and 'disable-unusable-tests.

Can the phase name 'disable-line' be made more explicit? I don't get
what it means in this context.

Otherwise LGTM!