From: "Ludovic Courtès" <ludo@gnu.org>
To: 36699@debbugs.gnu.org
Subject: [bug#36699] [PATCH 0/4] Strengthen '.guix-channel' file handling
Date: Wed, 17 Jul 2019 01:20:16 +0200 [thread overview]
Message-ID: <20190716232016.16559-1-ludo@gnu.org> (raw)
Hello Guix,
These patches change ‘.guix-channel’ parsing and handling following
the same pattern as <manifest>/read-manifest/profile-manifest and
other places where we deal with serialized data structures.
The last patch addresses a potential security issue with the
‘directory’ field of ‘.guix-channel’ that hadn’t occurred to me
while reviewing it.
Thoughts?
Ludo’.
Ludovic Courtès (4):
channels: Strictly check the version of '.guix-channel'.
channels: Remove unneeded 'version' field of <channel-metadata>.
channels: Always provide a <channel-metadata> record.
channels: Reject directories with '..' in '.guix-channel' file.
guix/channels.scm | 102 +++++++++++++++++++++++++++++----------------
tests/channels.scm | 81 +++++++++++++++++++++++++----------
2 files changed, 124 insertions(+), 59 deletions(-)
--
2.22.0
next reply other threads:[~2019-07-16 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 23:20 Ludovic Courtès [this message]
2019-07-16 23:24 ` [bug#36699] [PATCH 1/4] channels: Strictly check the version of '.guix-channel' Ludovic Courtès
2019-07-16 23:24 ` [bug#36699] [PATCH 2/4] channels: Remove unneeded 'version' field of <channel-metadata> Ludovic Courtès
2019-07-16 23:24 ` [bug#36699] [PATCH 3/4] channels: Always provide a <channel-metadata> record Ludovic Courtès
2019-07-16 23:24 ` [bug#36699] [PATCH 4/4] channels: Reject directories with '..' in '.guix-channel' file Ludovic Courtès
2019-07-16 23:29 ` Ludovic Courtès
2019-07-18 9:58 ` Danny Milosavljevic
2019-07-18 13:44 ` Ludovic Courtès
2019-07-19 9:54 ` bug#36699: [PATCH 0/4] Strengthen '.guix-channel' file handling Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716232016.16559-1-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=36699@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).