From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54974) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmQ5n-0002wu-2Q for guix-patches@gnu.org; Sat, 13 Jul 2019 18:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmQ5l-0006vh-TU for guix-patches@gnu.org; Sat, 13 Jul 2019 18:02:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34668) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmQ5l-0006vd-Qi for guix-patches@gnu.org; Sat, 13 Jul 2019 18:02:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmQ5l-0008D3-OD for guix-patches@gnu.org; Sat, 13 Jul 2019 18:02:05 -0400 Subject: [bug#36642] [PATCH 2/2] gnu: python-gst: Fix build failure. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:54499) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmQ4n-0002hJ-Es for guix-patches@gnu.org; Sat, 13 Jul 2019 18:01:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmQ4m-0005me-0F for guix-patches@gnu.org; Sat, 13 Jul 2019 18:01:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]:39966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmQ4l-0005ll-RY for guix-patches@gnu.org; Sat, 13 Jul 2019 18:01:03 -0400 Received: from localhost (148.185.93.209.dyn.plus.net [209.93.185.148]) by mira.cbaines.net (Postfix) with ESMTPSA id 1C76D1721D for ; Sat, 13 Jul 2019 23:01:03 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 9325faef for ; Sat, 13 Jul 2019 22:01:02 +0000 (UTC) From: Christopher Baines Date: Sat, 13 Jul 2019 23:01:02 +0100 Message-Id: <20190713220102.7416-2-mail@cbaines.net> In-Reply-To: <20190713220102.7416-1-mail@cbaines.net> References: <20190713220102.7416-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 36642@debbugs.gnu.org Building python-gst fails with: Unbound variable: python-version Therefore, add python-build-system to #:modules so that it's imported, an= d give it a prefix to avoid clashing with the gnu-build-system. Also, simplify the code by using the site-packages function from the python-build-system module. * gnu/packages/gstreamer.scm (python-gst)[arguments]: Rework to fix build failure. --- gnu/packages/gstreamer.scm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index b0f0b032b3..efb9a6f796 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -431,17 +431,14 @@ compression formats through the use of the libav li= brary.") "0f1d9rvy2qxlymmfzyknnfr5rz1vx69jv17gp7wnamc5s6p7mp2m"))= )) (build-system gnu-build-system) (arguments - ;; XXX: Factorize python-sitedir with python-build-system. - `(#:imported-modules (,@%gnu-build-system-modules + `(#:modules ((guix build gnu-build-system) + ((guix build python-build-system) #:prefix python:)) + #:imported-modules (,@%gnu-build-system-modules (guix build python-build-system)) #:configure-flags - (let* ((python (assoc-ref %build-inputs "python")) - (python-version (python-version python)) - (python-sitedir (string-append - "lib/python" python-version "/site-packag= es"))) - (list (string-append - "--with-pygi-overrides-dir=3D" %output "/" python-sitedi= r - "/gi/overrides"))))) + (list (string-append + "--with-pygi-overrides-dir=3D" %output "/" + (python:site-packages %build-inputs %outputs) "/gi/overrid= es")))) (native-inputs `(("pkg-config" ,pkg-config) ("python" ,python))) --=20 2.22.0