From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39326) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiCsZ-0003I7-Fd for guix-patches@gnu.org; Tue, 02 Jul 2019 03:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiCsY-0004U6-DI for guix-patches@gnu.org; Tue, 02 Jul 2019 03:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiCsY-0004U0-8D for guix-patches@gnu.org; Tue, 02 Jul 2019 03:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiCsY-00023k-1G for guix-patches@gnu.org; Tue, 02 Jul 2019 03:07:02 -0400 Subject: [bug#36440] [PATCH] Add FreeCAD Resent-Message-ID: Date: Tue, 2 Jul 2019 09:06:42 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20190702090642.2e07bc01@alma-ubu> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/E3=s.8TO8.Mx5SPv7Mozry9"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Soo Cc: 36440@debbugs.gnu.org --Sig_/E3=s.8TO8.Mx5SPv7Mozry9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 30 Jun 2019 02:39:52 +0000 John Soo wrote: > Hi all, >=20 > I've done linting, and indentation checks. There are still some > issues with licenses that I've marked and I don't know where to put > the changes that I've included in llvm.scm. Also I discovered some > non-determinism in the build of freecad just now. I thought it would > be good to share my work, though. It's been long enough. >=20 > - John Hi John, thank you very much for working on FreeCAD! And thanks for sharing this work even if it is not 100% polished. The first thing I noticed is that you packed everything into one commit. Could you please split it up in one commit per added/modified package? That's the usual way Guix expects commits, and it would make the reviewing easier, you can concentrate on each package as a reviewer and you better see the dependency structure right away. Thanks, Bj=C3=B6rn --Sig_/E3=s.8TO8.Mx5SPv7Mozry9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXRsCggAKCRC/KGy2WT5f /ekmAJ9duHFOgQ9bvyHczKPfvT+apYvEOwCeK6g7D+0KYJFjCivWPVhCINsmbxw= =SvwO -----END PGP SIGNATURE----- --Sig_/E3=s.8TO8.Mx5SPv7Mozry9--