From: Tobias Geerinckx-Rice <me@tobias.gr>
To: 36132@debbugs.gnu.org
Subject: [bug#36132] [PATCH 1/2] installer: Partition as the last step.
Date: Sat, 8 Jun 2019 06:47:28 +0200 [thread overview]
Message-ID: <20190608044729.14700-1-me@tobias.gr> (raw)
In-Reply-To: <87y32c663d.fsf@nckx>
Multiple users have been understandably displeased after finding out
that their network card was unsupported, and Internet access mandatory,
after having already formatted their partitions.
* gnu/installer.scm (installer-steps): Run the ‘partition’ step just
before the ‘final’ one.
---
gnu/installer.scm | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1452c4dc7e..860c5a9a83 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -226,15 +227,6 @@ selected keymap."
(#$keymap-step current-installer)))
(configuration-formatter keyboard-layout->configuration))
- ;; Run a partitioning tool allowing the user to modify
- ;; partition tables, partitions and their mount points.
- (installer-step
- (id 'partition)
- (description (G_ "Partitioning"))
- (compute (lambda _
- ((installer-partition-page current-installer))))
- (configuration-formatter user-partitions->configuration))
-
;; Ask the user to input a hostname for the system.
(installer-step
(id 'hostname)
@@ -267,6 +259,17 @@ selected keymap."
((installer-services-page current-installer))))
(configuration-formatter system-services->configuration))
+ ;; Run a partitioning tool allowing the user to modify
+ ;; partition tables, partitions and their mount points.
+ ;; Do this last so the user has something to boot if any
+ ;; of the previous steps doesn't go as expected.
+ (installer-step
+ (id 'partition)
+ (description (G_ "Partitioning"))
+ (compute (lambda _
+ ((installer-partition-page current-installer))))
+ (configuration-formatter user-partitions->configuration))
+
(installer-step
(id 'final)
(description (G_ "Configuration file"))
--
2.21.0
next prev parent reply other threads:[~2019-06-08 4:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 4:42 [bug#36132] Two installer UX tweaks Tobias Geerinckx-Rice
2019-06-08 4:47 ` Tobias Geerinckx-Rice [this message]
2019-06-08 4:47 ` [bug#36132] [PATCH 2/2] installer: Show, don't Hide Tobias Geerinckx-Rice
2019-06-11 8:05 ` Ludovic Courtès
2019-06-11 8:02 ` [bug#36132] [PATCH 1/2] installer: Partition as the last step Ludovic Courtès
2019-08-26 14:23 ` [bug#35901] " Tobias Geerinckx-Rice via Guix-patches via
2019-08-26 14:00 ` bug#36132: Two installer UX tweaks Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608044729.14700-1-me@tobias.gr \
--to=me@tobias.gr \
--cc=36132@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).