From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "Ludovic Courtès" <ludovic.courtes@inria.fr>, 36093@debbugs.gnu.org
Subject: [bug#36093] [PATCH 2/2] pack: Add '--entry-point'.
Date: Wed, 5 Jun 2019 17:06:53 +0200 [thread overview]
Message-ID: <20190605170653.5be950ca@scratchpost.org> (raw)
In-Reply-To: <20190604210115.24477-2-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
Hi Ludo,
On Tue, 4 Jun 2019 23:01:15 +0200
Ludovic Courtès <ludo@gnu.org> wrote:
> + ,@(if entry-point
> + `(;; This one if for Singularity 2.x.
> + "-p"
> + ,(string-append
> + "/.singularity.d/actions/run s 777 0 0 "
> + (relative-file-name "/.singularity.d/actions"
> + (string-append #$profile "/"
> + entry-point)))
> +
> + ;; This one is for Singularity 3.x.
> + "-p"
> + ,(string-append
> + "/.singularity.d/runscript s 777 0 0 "
> + (relative-file-name "/.singularity.d"
> + (string-append #$profile "/"
> + entry-point))))
Hmm, 777 (anyone can write)? It it necessary?
Also, in general, do we conflate "squashfs" and "singularity"? It has been
that way in guix/scripts/pack.scm's squashfs-image before this patch already
and a few extra files can't hurt, but we could also just provide a
function "singularity-image" or something.
LGTM!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-05 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 20:51 [bug#36093] [PATCH 0/2] 'guix pack --entry-point' and Singularity service Ludovic Courtès
2019-06-04 21:01 ` [bug#36093] [PATCH 1/2] services: Add Singularity Ludovic Courtès
2019-06-04 21:01 ` [bug#36093] [PATCH 2/2] pack: Add '--entry-point' Ludovic Courtès
2019-06-05 15:06 ` Danny Milosavljevic [this message]
2019-06-05 20:27 ` Ludovic Courtès
2019-06-06 11:03 ` [bug#36093] [PATCH v2 1/2] services: Add Singularity Ludovic Courtès
2019-06-06 11:03 ` [bug#36093] [PATCH v2 2/2] pack: Add '--entry-point' Ludovic Courtès
2019-06-07 7:58 ` bug#36093: " Ludovic Courtès
2019-06-07 10:21 ` [bug#36093] [PATCH " Ricardo Wurmus
2019-06-07 13:15 ` Ludovic Courtès
2019-06-08 17:21 ` Ricardo Wurmus
2019-06-05 15:02 ` [bug#36093] [PATCH 1/2] services: Add Singularity Danny Milosavljevic
2019-06-05 20:24 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605170653.5be950ca@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=36093@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).