unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: "h.nasajpour" <h.nasajpour@pantherx.org>
Cc: 35949@debbugs.gnu.org
Subject: [bug#35949] [PATCH 3/3] gnu: Add python-flask-cors.
Date: Tue, 28 May 2019 21:09:44 +0200	[thread overview]
Message-ID: <20190528210944.5ad9cd56@scratchpost.org> (raw)
In-Reply-To: <20190528105743.3749-1-h.nasajpour@pantherx.org>

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

Hi,

On Tue, 28 May 2019 15:27:43 +0430
"h.nasajpour" <h.nasajpour@pantherx.org> wrote:

> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "Flask-Cors" version))
> +      (sha256 (base32 "1v6gq4vjgyxi8q8lxawpdfhq01adb4bznnabp08ks5nzbwibz43y"))))

Strange indentation. 

> +    (arguments
> +     `(#:tests? #f))

Please add a comment with the reason.
 
> +    (propagated-inputs
> +      `(("python-six" ,python-six)
> +        ("python-flask" ,python-flask)))
> +    (home-page "https://github.com/corydolphin/flask-cors")
> +    (synopsis "A Flask extension adding a decorator for CORS support")
> +    (description
> +     "A Flask extension adding a decorator for CORS support")

Please add text to the description that describes what CORS is.
Also, the description should be full sentences.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-05-28 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 10:57 [bug#35949] [PATCH 3/3] gnu: Add python-flask-cors h.nasajpour
2019-05-28 19:09 ` Danny Milosavljevic [this message]
2019-05-29  0:58   ` Hamzeh Nasajpour
2019-07-29  6:45     ` Hamzeh Nasajpour
2019-12-10  6:34     ` Brett Gilio
2022-04-07 13:07 ` bug#35949: " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528210944.5ad9cd56@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=35949@debbugs.gnu.org \
    --cc=h.nasajpour@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).