From: Reza Alizadeh Majd <r.majd@pantherx.org>
To: 35749@debbugs.gnu.org
Cc: Reza Alizadeh Majd <r.majd@pantherx.org>
Subject: [bug#35749] [PATCH 1/2] services: sddm: fix root login failure issue.
Date: Tue, 21 May 2019 16:12:45 +0430 [thread overview]
Message-ID: <20190521114246.82283-1-r.majd@pantherx.org> (raw)
In-Reply-To: <20190515141154.31832-1-r.majd@pantherx.org>
* gnu/services/sddm.scm
(sdm-pam-service): set uid from config.
(sdm-autologin-pam-service): set uid from config.
(sdm-pam-services): pass sddm-configuration to sddm-pam-service and
sddm-autologin-pam-service
---
gnu/services/sddm.scm | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b433c59e12..b0e6d40260 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -175,7 +175,7 @@ Relogin=" (if (sddm-configuration-relogin? config)
(define (sddm-etc-service config)
(list `("sddm.conf" ,(sddm-configuration-file config))))
-(define (sddm-pam-service)
+(define (sddm-pam-service config)
"Return a PAM service for @command{sddm}."
(pam-service
(name "sddm")
@@ -190,7 +190,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(pam-entry
(control "required")
(module "pam_succeed_if.so")
- (arguments (list "uid >= 1000" "quiet")))
+ (arguments (list (string-append "uid >= "
+ (number->string (sddm-configuration-minimum-uid config)))
+ "quiet")))
;; should be factored out into system-auth
(pam-entry
(control "required")
@@ -249,7 +251,7 @@ Relogin=" (if (sddm-configuration-relogin? config)
(control "required")
(module "pam_unix.so"))))))
-(define (sddm-autologin-pam-service)
+(define (sddm-autologin-pam-service config)
"Return a PAM service for @command{sddm-autologin}"
(pam-service
(name "sddm-autologin")
@@ -261,7 +263,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(pam-entry
(control "required")
(module "pam_succeed_if.so")
- (arguments (list "uid >= 1000" "quiet")))
+ (arguments (list (string-append "uid >= "
+ (number->string (sddm-configuration-minimum-uid config)))
+ "quiet")))
(pam-entry
(control "required")
(module "pam_permit.so"))))
@@ -282,9 +286,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(module "sddm"))))))
(define (sddm-pam-services config)
- (list (sddm-pam-service)
+ (list (sddm-pam-service config)
(sddm-greeter-pam-service)
- (sddm-autologin-pam-service)))
+ (sddm-autologin-pam-service config)))
(define %sddm-accounts
(list (user-group (name "sddm") (system? #t))
--
2.19.0
next prev parent reply other threads:[~2019-05-21 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 14:11 [bug#35749] [PATCH] services: sddm: fix root login failure issue Reza Alizadeh Majd
2019-05-15 14:34 ` [bug#35749] SDDM root login issue Reza Alizadeh Majd
2019-05-20 21:16 ` [bug#35749] [PATCH] services: sddm: fix root login failure issue Ludovic Courtès
2019-05-21 11:26 ` Reza Alizadeh Majd
2019-05-21 13:17 ` Ludovic Courtès
2019-05-21 13:21 ` Reza Alizadeh Majd
2019-05-21 11:42 ` Reza Alizadeh Majd [this message]
2019-05-21 11:42 ` [bug#35749] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration Reza Alizadeh Majd
2019-10-15 19:38 ` bug#35749: [PATCH] services: sddm: fix root login failure issue Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521114246.82283-1-r.majd@pantherx.org \
--to=r.majd@pantherx.org \
--cc=35749@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).