From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRRVe-00014D-MH for guix-patches@gnu.org; Thu, 16 May 2019 21:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRRVd-0002lQ-P5 for guix-patches@gnu.org; Thu, 16 May 2019 21:18:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRRVd-0002lL-MA for guix-patches@gnu.org; Thu, 16 May 2019 21:18:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRRVd-0007HI-H5 for guix-patches@gnu.org; Thu, 16 May 2019 21:18:05 -0400 Subject: [bug#35720] [PATCH] gnu: Add chocolate-doom. Resent-Message-ID: Date: Thu, 16 May 2019 19:21:24 -0400 From: "Jakob L. Kreuze" Message-ID: <20190516232124.GA7468@sdf.lonestar.org> References: <20190513194251.GA18548@sdf.lonestar.org> <871s0ygo9s.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <871s0ygo9s.fsf@dustycloud.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Lemmer Webber Cc: 35720@debbugs.gnu.org --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hey, Chris! On Thu, May 16, 2019 at 04:03:43PM -0400, Christopher Lemmer Webber wrote: > - I think it would be "New variable" rather than "New variables" in > the commit message. Not that this is a big deal, and I could fix > it. If I update the patch to address your second point, I can change it. Otherwise, if you'd be willing to fix it when merging, that'd be great. > - It would be good to test if it can run with freedoom (a libre doom > content replacement for doom that's functionaly similar). My guess > is that the one change would need to be adjusting where the default > searched WAD path is. freedoom and gzdoom both add a reference to > /share/games/doom so I'm guessing that's how it's found. However > I'm not positive about that. GZDoom adds a reference to /share/games/doom because it bundles a .pk3 file containing some port-specific things which ends up in the store, and my understanding is that Freedoom updates DOOMWADDIR and DOOMWADPATH to point to where the wads are in the profile, so I don't think patching the search paths is necessary. Thanks for reviewing this! Jakob --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAlzd8HEACgkQ9Qb9Fp2P 2Vr4Cw//VT8LbPbb5ZfSpOND6Ngad9oXd8+KUVj6GY3QYvxx8LVcpC66s/hBAxbl uSfnIzxybml4aNckTg4J53qlqx1walm6ok25Z80nCNg1HkRiGUQ6XtLrCVNZyJti 0cb0SQ2NTSidjs1uzFE9mStwWvKXhFx+n6BD7OpXAzS1tKM3u8MG/32KxOTDLTjH 9IJezja6P05LLdIYWnfWHKBCKsEFyyinjXBQEBmJndwEmiAmpKnpKxjVMiTwUUM+ PejmfbRX2PIwrJ5jrHWIbDZy8uzrwHvg2Rz9/Wvg6dTXGtkSMUs/5BYVxNrugASF 2x003gQI5LkP6+A5UPMSGiKCxdeP3+5m8jRb3HS/W+jDLsmtJpba4vPJ65/xOAyx TllcbphiH/IK4O25QfCqsvCMwwGjK7m8/zn6fYNvECHLw17ktMCv3cQSNNfLocJI Og51IZNe3Z7WNTofnXpQjpLgJm747gGhiTFuFFZ+vt0EY/OdbyATW38ahjyDNrNR NVEXr7F9xUb6qEJMg/QIyW4PIOzzSphAHAvhaGbfIL9qPHq50VFR/+qB25Otqexd YPFY3KvY82z0qnTSfDE3rMQGtpad4awkY4XfJgYKq/Mv3Ll0VOEfAhb2EJwp2NY8 GdmwfOyrJIm9hvZDLQhZz9KhlZTmukn7F5Uxo1rS63bVKsvFIaI= =zeZG -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--