From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOnKv-0000MQ-1E for guix-patches@gnu.org; Thu, 09 May 2019 14:00:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOnKu-0001Wh-3D for guix-patches@gnu.org; Thu, 09 May 2019 14:00:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOnKt-0001WC-Be for guix-patches@gnu.org; Thu, 09 May 2019 14:00:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOnKt-00017f-1y for guix-patches@gnu.org; Thu, 09 May 2019 14:00:03 -0400 Subject: [bug#35653] [PATCH] gnu: Add rcm. Resent-Message-ID: From: Josh Holland Date: Thu, 9 May 2019 18:59:15 +0100 Message-Id: <20190509175916.22479-1-josh@inv.alid.pw> In-Reply-To: <20190509185256.309d9b63@scratchpost.org> References: <20190509185256.309d9b63@scratchpost.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 35653@debbugs.gnu.org Danny Milosavljevic writes: > Yes, and it's not so important in which module what is. I'll just leave it in its own module for now then, and if a maintainer wants to move it either when it's merged or later down the line that's fine. > From your description, try (#:parallel-tests? #f) instead of (#:tests? #f). Oh of course, that makes perfect sense! That fixes it and all the tests pass now. > Some test scripts still have /bin/sh AFAICT the only one I'm not patching is `test/rcup-standalone.t` and that's kind of a weird one, because it's testing the feature to output a standalone shell script rather than run it. Changing that would require patching the rcup script itself and I don't think that's worth it, especially as the script uses the bash default value syntax to allow all the commands to be overriden. If I'm still operating git send-email correctly, a new patch should be attached with these changes, and a better commit message. I also updated `gnu/local.mk` because that seems to be a thing I forgot initially. Thanks, Josh