From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNPXE-0001Nc-9L for guix-patches@gnu.org; Sun, 05 May 2019 18:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNPXC-00076L-HA for guix-patches@gnu.org; Sun, 05 May 2019 18:23:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNPXC-000768-Bg for guix-patches@gnu.org; Sun, 05 May 2019 18:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hNPXC-00085H-5F for guix-patches@gnu.org; Sun, 05 May 2019 18:23:02 -0400 Subject: [bug#35545] [PATCH 17/17] gnu: Add josm. Resent-Message-ID: Date: Mon, 6 May 2019 00:22:37 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20190506002237.525e30b0@alma-ubu> In-Reply-To: <20190503130134.24788-17-julien@lepiller.eu> References: <20190503145820.606f37db@sybil.lepiller.eu> <20190503130134.24788-1-julien@lepiller.eu> <20190503130134.24788-17-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/JrZJovMfix294tadyn3HprK"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 35545@debbugs.gnu.org --Sig_/JrZJovMfix294tadyn3HprK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 3 May 2019 15:01:34 +0200 Julien Lepiller wrote: > * gnu/packages/geo.scm (josm): New variable. > --- > gnu/packages/geo.scm | 134 > +(define-public josm > + (package > + (name "josm") > + (version "15031") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url > "https://github.com/openstreetmap/josm.git") > + (commit > "04d4c64b1b5698c0f9af40938f32194bc25bf75f"))) Checking out josm from git took at least 15 minutes, with the following message: building /gnu/store/4k4p9gm7jcrga0y1bk5rnq7025691kij-josm-15031-checkout.dr= v... environment variable `PATH' set to `/gnu/store/q09sy224qnxrp982z4xfaxi19721= mjx8-gzip-1.9/bin:/gnu/store/ipx79bfj2mrc8npj7s3qi3zri11jfhaw-tar-1.30/bi> Initialized empty Git repository in /gnu/store/irx9c08wfp9g48ilrlj8z2xndl3z= 45l4-josm-15031-checkout/.git/ error: Server does not allow request for unadvertised object 04d4c64b1b5698= c0f9af40938f32194bc25bf75f Failed to do a shallow fetch; retrying a full fetch... =46rom https://github.com/openstreetmap/josm * [new branch] master -> origin/master * [new branch] mirror -> origin/mirror Note: checking out '04d4c64b1b5698c0f9af40938f32194bc25bf75f'. Have you tried out the original svn-checkout? Would that be faster? At least it would better reflect the version, as this is the SVN commit id. [..] > + (add-after 'install 'install-bin > + (lambda* (#:key outputs inputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (mkdir-p bin) > + (with-output-to-file (string-append bin "/josm") > + (lambda _ > + (display > + (string-append "#!/bin/sh\n" > + (assoc-ref inputs "jdk") > "/bin/java" I wonder where "jdk" comes in. I suppose it is some implicit (native?) input from the ant-build-system. When I do a "guix gc --reference" I see that it is referenced. Thus, it wouldn't be garbage-collected away at least. But wouldn't it be better to have the java-runtime (java:out) as an explicit input and use that? Then it is first explicit and second would use less space for people who do not need the full JDK. Though sometimes programs NEED parts of the JDK, not only from the runtime. I wonder if josm needs a JDK (usually these programs are more server-oriented). > + (license license:gpl2+))) I found some files under LGPL (though not mentioned in the REAMDE/LICENSE file :-)), like: ./src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java Looks like they are from Swing, I wonder if they are in any way modified from the original ones. While running the application: I see a lot of NPEs on the console complaining about icons, though when I run it, it looks good. I don't miss anything compared to my downloaded josm-latest.jar. When looking into the installed josm.jar, I find these: 24452 Tue Jan 01 00:00:00 CET 1980 images/presets/shop/kiosk.svg But still having this error on the console: 2019-05-05 21:34:04.152 WARNING: Could not load SVG jar:file:/gnu/store/msb= v0zpiwdjax2dwa3s9ml3idpc86bxp-josm-15031/share/java/josm.jar!/images/preset= s/shop/kiosk.svg java.lang.NullPointerException at com.kitfox.svg.Tspan.appendToShape(Tspan.java:281) at com.kitfox.svg.Text.buildText(Text.java:362) at com.kitfox.svg.Text.build(Text.java:266) at com.kitfox.svg.Text.updateTime(Text.java:610) at com.kitfox.svg.Group.updateTime(Group.java:313) at com.kitfox.svg.Group.updateTime(Group.java:313) at com.kitfox.svg.SVGRoot.updateTime(SVGRoot.java:403) at com.kitfox.svg.SVGDiagram.updateTime(SVGDiagram.java:243) at com.kitfox.svg.SVGUniverse.loadSVG(SVGUniverse.java:616) at com.kitfox.svg.SVGUniverse.loadSVG(SVGUniverse.java:468) at com.kitfox.svg.SVGUniverse.loadSVG(SVGUniverse.java:445) at org.openstreetmap.josm.tools.ImageProvider.getIfAvailableLocalURL(Unkno= wn Source) at org.openstreetmap.josm.tools.ImageProvider.getIfAvailableImpl(Unknown S= ource) at org.openstreetmap.josm.tools.ImageProvider.getResource(Unknown Source) at org.openstreetmap.josm.tools.ImageProvider.getResourceAsync(Unknown Sou= rce) at org.openstreetmap.josm.gui.tagging.presets.TaggingPreset.setIcon(Unknow= n Source) at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.openstreetmap.josm.tools.XmlObjectParser$Parser.setValue(Unknown So= urce) at org.openstreetmap.josm.tools.XmlObjectParser$Parser.startElement(Unknow= n Source) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startEleme= nt(AbstractSAXParser.java:509) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanSt= artElement(XMLNSDocumentScannerImpl.java:374) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$= FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2784) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XML= DocumentScannerImpl.java:602) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(X= MLNSDocumentScannerImpl.java:112) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.= scanDocument(XMLDocumentFragmentScannerImpl.java:505) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:842) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:771) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.ja= va:141) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abst= ractSAXParser.java:1213) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.par= se(SAXParserImpl.java:643) at org.openstreetmap.josm.tools.XmlObjectParser.start(Unknown Source) at org.openstreetmap.josm.tools.XmlObjectParser.start(Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader.readAll(= Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader.readAll(= Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader.readAll(= Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader.readFrom= Preferences(Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresets.readFromPrefe= rences(Unknown Source) at org.openstreetmap.josm.gui.tagging.presets.TaggingPresets.initialize(Un= known Source) at org.openstreetmap.josm.spi.lifecycle.InitializationTask.call(Unknown So= urce) at org.openstreetmap.josm.spi.lifecycle.InitializationTask.call(Unknown So= urce) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.ja= va:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.j= ava:624) at java.lang.Thread.run(Thread.java:748) Plugins: I will continue the discussions where I started. Thanks again for getting that into Guix! Bj=C3=B6rn --Sig_/JrZJovMfix294tadyn3HprK Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXM9iLQAKCRC/KGy2WT5f /S63AJ4wCmW29ZHPNmF/E1OxlUYd58+gCwCfQhmxEJpCGlgsNmzP4rJ4BPDl3cA= =9uD6 -----END PGP SIGNATURE----- --Sig_/JrZJovMfix294tadyn3HprK--