[bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.

[bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.

[Danny Milosavljevic]

Fixes <https://bugs.gnu.org/35582>.
Reported by sirgazil <sirgazil@zoho.com>.

* gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
zeroes.
---
 gnu/system/uuid.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm
index f13960c3e9..7204d163d0 100644
--- a/gnu/system/uuid.scm
+++ b/gnu/system/uuid.scm
@@ -175,7 +175,7 @@ ISO9660 UUID representation."
   "Convert FAT32/FAT16 UUID, a 4-byte bytevector, to its string representation."
   (let ((high  (bytevector-uint-ref uuid 0 %fat-endianness 2))
         (low (bytevector-uint-ref uuid 2 %fat-endianness 2)))
-    (format #f "~:@(~x-~x~)" low high)))
+    (format #f "~:@(~4,'0x-~4,'0x~)" low high)))
 
 (define %fat-uuid-rx
   (make-regexp "^([[:xdigit:]]{4})-([[:xdigit:]]{4})$"))

bug#35593: [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.

[Ludovic Courtès]

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Fixes <https://bugs.gnu.org/35582>.
> Reported by sirgazil <sirgazil@zoho.com>.
>
> * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> zeroes.

Bah, I feel guilty: I pushed the same patch with a test as
6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that
you had fixed it too.  My apologies!

Perhaps in the future you should send the patch directly in the bug
report?  That would increase the likelihood that I’ll notice and won’t
duplicate work.

(Perhaps in the future I should also pay more attention to email…
tricky!)

Ludo’.

[bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Hi Ludo,

On Thu, 09 May 2019 12:10:55 +0200
Ludovic Courtès <ludo@gnu.org> wrote:

> > Fixes <https://bugs.gnu.org/35582>.
> > Reported by sirgazil <sirgazil@zoho.com>.
> >
> > * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> > zeroes.  
> 
> Bah, I feel guilty: I pushed the same patch with a test as
> 6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that
> you had fixed it too.  My apologies!

Don't worry.  It's good that someone fixes it, doesn't matter whether it's you
or me :)

> Perhaps in the future you should send the patch directly in the bug
> report?  That would increase the likelihood that I’ll notice and won’t
> duplicate work.

Sure!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]