From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMt1Q-0007tR-Pd
	for guix-patches@gnu.org; Sat, 04 May 2019 07:40:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMt1O-00039v-Q2
	for guix-patches@gnu.org; Sat, 04 May 2019 07:40:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:36927)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hMt1O-00039c-E5
	for guix-patches@gnu.org; Sat, 04 May 2019 07:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMt1O-0006to-AX
	for guix-patches@gnu.org; Sat, 04 May 2019 07:40:02 -0400
Subject: [bug#35545] [PATCH 08/17] gnu: Add java-openjfx-base.
Resent-Message-ID: <handler.35545.B35545.155696995126448@debbugs.gnu.org>
Date: Sat, 4 May 2019 13:38:50 +0200
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20190504133850.71eddeb5@sybil.lepiller.eu>
In-Reply-To: <87v9yrvabq.fsf@nicolasgoaziou.fr>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-8-julien@lepiller.eu>
	<87v9yrvabq.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 35545@debbugs.gnu.org

Le Fri, 03 May 2019 17:15:05 +0200,
Nicolas Goaziou <mail@nicolasgoaziou.fr> a =C3=A9crit :

> Hello,
>=20
> Julien Lepiller <julien@lepiller.eu> writes:
>=20
> > +         (add-before 'check 'remove-empty-file
> > +           (lambda _
> > +             (with-directory-excursion "modules/base/src/test/java"
> > +               ;; These files are completely commented, but junit
> > expects them to
> > +               ;; contain a class, so tests fail.
> > +               (delete-file
> > +
> > "com/sun/javafx/property/adapter/PropertyDescriptorTest.java")
> > +               (delete-file
> > +
> > "com/sun/javafx/property/adapter/ReadOnlyPropertyDescriptorTest.java")
> > +               (delete-file
> > "javafx/beans/property/PropertiesTest.java")
> > +               (delete-file
> > +
> > "javafx/beans/property/adapter/ReadOnlyJavaBeanPropertyBuilder_General_=
Test.java")
> > +               ;; This one fails
> > +               (delete-file
> > "com/sun/javafx/runtime/VersionInfoTest.java"))))))) =20
>=20
> This phase doesn't end with #t.
>=20
> Regards,
>=20

Thanks! I fixed that and your comment on patch 07. Is there anything
more? Do you need more time for a complete review or have you reviewed
everything already?