unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brendan Tildesley <mail@brendan.scot>
To: 35446@debbugs.gnu.org
Subject: [bug#35446] [PATCH v2 13/24] gnu: calibre: Disable bs4 test.
Date: Sat,  4 May 2019 02:42:21 +1000	[thread overview]
Message-ID: <20190503164232.1799-13-mail@brendan.scot> (raw)
In-Reply-To: <20190503164232.1799-1-mail@brendan.scot>

* gnu/local.mk: Reference patch
  gnu/packages/ebook.scm (calibre)[origin]: Enable patch.
  gnu/packages/patches/calibre-remove-test-bs4.patch: New file.

In my efforts to fix all Calibre tests, this test would always complain about
backports.functools_lru_cache not existing even after I packaged and added
python2-soupsieve as an input and confirmed it was in the
PYTHONPATH. Currently Calibre does not actually use it for anything other than
testing it's there, so I assume they will start using it in future Calibre
versions.
---
 gnu/local.mk                                  |  1 +
 gnu/packages/ebook.scm                        |  1 +
 .../patches/calibre-remove-test-bs4.patch     | 27 +++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 gnu/packages/patches/calibre-remove-test-bs4.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index d5b7a2c5e5..9e31868281 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -690,6 +690,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/boost-fix-icu-build.patch		\
   %D%/packages/patches/byobu-writable-status.patch		\
   %D%/packages/patches/calibre-no-updates-dialog.patch		\
+  %D%/packages/patches/calibre-remove-test-bs4.patch		\
   %D%/packages/patches/calibre-remove-test-unrar.patch		\
   %D%/packages/patches/casync-renameat2-declaration.patch	\
   %D%/packages/patches/catdoc-CVE-2017-11110.patch		\
diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index 964fdd7b75..05a9b96d35 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -97,6 +97,7 @@
             (delete-file "src/odf/thumbnail.py")
             #t))
         (patches (search-patches "calibre-no-updates-dialog.patch"
+                                 "calibre-remove-test-bs4.patch" ;; TODO: fix test.
                                  "calibre-remove-test-unrar.patch"))))
     (build-system python-build-system)
     (native-inputs
diff --git a/gnu/packages/patches/calibre-remove-test-bs4.patch b/gnu/packages/patches/calibre-remove-test-bs4.patch
new file mode 100644
index 0000000000..2c566baeb6
--- /dev/null
+++ b/gnu/packages/patches/calibre-remove-test-bs4.patch
@@ -0,0 +1,27 @@
+From 2738dd42caebe55326c76922a12ba8740bdb22e7 Mon Sep 17 00:00:00 2001
+From: Brendan Tildesley <mail@brendan.scot>
+Date: Sat, 27 Apr 2019 00:42:39 +1000
+Subject: [PATCH] Remove test_bs4
+
+---
+ src/calibre/test_build.py | 4 ----
+ 1 file changed, 4 deletions(-)
+
+diff --git a/src/calibre/test_build.py b/src/calibre/test_build.py
+index 73f1172e8c..07bdffd3e5 100644
+--- a/src/calibre/test_build.py
++++ b/src/calibre/test_build.py
+@@ -73,10 +73,6 @@ class BuildTest(unittest.TestCase):
+         from html5_parser import parse
+         parse('<p>xxx')
+ 
+-    def test_bs4(self):
+-        import soupsieve, bs4
+-        del soupsieve, bs4
+-
+     def test_zeroconf(self):
+         if ispy3:
+             import zeroconf as z, ifaddr
+-- 
+2.21.0
+
-- 
2.21.0

  parent reply	other threads:[~2019-05-03 16:45 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27  6:36 [bug#35446] [PATCH 0/26] Calibre: Update to 3.41.3 Brendan Tildesley
2019-04-27  9:36 ` [bug#35446] [PATCH 01/26] gnu: Use 'license:' prefix in (gnu packages web) Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 02/26] gnu: Add python-css-parser, python2-css-parser Brendan Tildesley
2019-05-03 11:48     ` Andreas Enge
2019-04-27  9:36   ` [bug#35446] [PATCH 03/26] gnu: calibre: Update to 3.41.3 Brendan Tildesley
2019-05-03 11:57     ` Andreas Enge
2019-05-03 16:49       ` Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 04/26] gnu: calibre: Remove feedparser patch Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 05/26] Update email address for Brendan Tildesley Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 06/26] gnu: calibre: [inputs]: Replace cssutils with the css-parser fork Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 07/26] gnu: calibre: Remove markdown unbundling code Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 08/26] gnu: calibre: Use system mathjax Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 09/26] gnu: calibre: Build rapydscript Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 10/26] gnu: calibre: Enable tests Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 11/26] gnu: calibre: Add missing dependencies as indicated by tests Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 12/26] gnu: calibre: Patch out unrar test Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 13/26] gnu: calibre: Move font unbundling to after check phase Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 14/26] gnu: Add python-html2text, python2-html2text Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 15/26] gnu: calibre: Add python2-html2text as an input Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 16/26] gnu: python-regex, python2-regex: Update to 2019.04.14 Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 17/26] gnu: calibre: Disable tests that require networking Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 18/26] gnu: Add python-soupsieve, python2-soupsieve Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 19/26] gnu: calibre: Use linux.py to install desktop files Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 20/26] gnu: calibre: Disable bs4 test Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 21/26] gnu: calibre: Disable Qt test Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 22/26] gnu: calibre: Disable bs4 test Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 23/26] gnu: Calibre: Remove some comments Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 24/26] gnu: calibre: Unbundle python2-odfpy Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 25/26] gnu: calibre: Remove libxrender as an input Brendan Tildesley
2019-04-27  9:36   ` [bug#35446] [PATCH 26/26] gnu: calibre: Delete various junk from source Brendan Tildesley
2019-04-27 10:14 ` [bug#35446] [PATCH 25/26]: gnu: calibre: Delete various junk from source. (fix typos) Brendan Tildesley
2019-05-03 11:22 ` [bug#35446] [PATCH 0/26] Calibre: Update to 3.41.3 Andreas Enge
2019-05-03 16:42 ` [bug#35446] [PATCH v2 01/24] gnu: calibre: " Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 02/24] gnu: calibre: Use system mathjax Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 03/24] gnu: calibre: Build rapydscript Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 04/24] gnu: calibre: Add missing dependencies as indicated by tests Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 05/24] gnu: calibre: Patch out unrar test Brendan Tildesley
2019-05-05 11:19     ` Danny Milosavljevic
2019-05-05 11:32       ` Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 06/24] gnu: calibre: Move font unbundling to after check phase Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 07/24] gnu: Add python-html2text, python2-html2text Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 08/24] gnu: calibre: Add python2-html2text as an input Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 09/24] gnu: python-regex, python2-regex: Update to 2019.04.14 Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 10/24] gnu: calibre: Disable tests that require networking Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 11/24] gnu: Add python-soupsieve, python2-soupsieve Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 12/24] gnu: calibre: Use linux.py to install desktop files Brendan Tildesley
2019-05-03 16:42   ` Brendan Tildesley [this message]
2019-05-03 16:42   ` [bug#35446] [PATCH v2 14/24] gnu: calibre: Disable Qt test Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 15/24] gnu: calibre: Disable sqlite test Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 16/24] gnu: calibre: Enable tests Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 17/24] gnu: calibre: Remove some comments Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 18/24] gnu: calibre: Unbundle python2-odfpy Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 19/24] gnu: calibre: Remove libxrender as an input Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 20/24] gnu: calibre: Delete various junk from source Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 21/24] gnu: calibre: Install man pages Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 22/24] gnu: calibre: Shorten long line Brendan Tildesley
2019-05-03 16:42   ` [bug#35446] [PATCH v2 23/24] gnu: calibre: Update to 3.42.0 Brendan Tildesley
2019-05-05 15:15     ` bug#35446: " Danny Milosavljevic
2019-05-03 16:42   ` [bug#35446] [PATCH v2 24/24] Correct email and license info for Brendan Tildesley Brendan Tildesley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503164232.1799-13-mail@brendan.scot \
    --to=mail@brendan.scot \
    --cc=35446@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).