From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:39706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJiUc-0005e1-44
	for guix-patches@gnu.org; Thu, 25 Apr 2019 13:49:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJiUY-0005rt-LW
	for guix-patches@gnu.org; Thu, 25 Apr 2019 13:49:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45724)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hJiUY-0005rU-Hl
	for guix-patches@gnu.org; Thu, 25 Apr 2019 13:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJiUY-0001IU-AP
	for guix-patches@gnu.org; Thu, 25 Apr 2019 13:49:02 -0400
Subject: bug#35330: [PATCH] gnu: certbot: Add support for manual plugin.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35330.D35330.15562145204950.done@debbugs.gnu.org>
Date: Thu, 25 Apr 2019 19:48:21 +0200
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20190425194821.191f4b22@sybil.lepiller.eu>
In-Reply-To: <875zr3egdj.fsf@gnu.org>
References: <20190419212320.20256-1-julien@lepiller.eu>
	<875zr3egdj.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 35330-done@debbugs.gnu.org

Le Wed, 24 Apr 2019 14:29:12 +0200,
Ludovic Court=C3=A8s <ludo@gnu.org> a =C3=A9crit :

> Hello,
>=20
> Julien Lepiller <julien@lepiller.eu> skribis:
>=20
> > * gnu/services/certbot.scm (certificate-configuration): Add
> > challenge, auth-hook and cleanup-hook fields.
> > (certbot-command): Use them.
> > * doc/guix.texi (Certificate Services): Document them. =20
>=20
> Neat!
>=20
> Nitpick:
>=20
>   - s/http/HTTP/
>   - two spaces after end-of-sentence period
>   - s/filename/file name/
>=20
> > +@item @code{challenge} (default: @code{#f})
> > +The challenge type that has to be run by certbot. If @code{#f} is
> > specified, +default to the http challenge. If a value is specified,
> > defaults to the +manual plugin (see @code{auth-hook} and
> > @code{cleanup-hook}). =20
>=20
> If there=E2=80=99s a stable URL to upstream documentation, perhaps you co=
uld
> insert it here.
>=20
> > +@item @code{auth-hook} (default: @code{#f}) =20
>=20
> Should it be called =E2=80=98authentication-hook=E2=80=99?
>=20
> I=E2=80=99m definitely no expert, but I=E2=80=99d say go for it!
>=20
> Thanks for working on it!
>=20
> Ludo=E2=80=99.

Thanks, pushed as b68aff1f05864a589b62afa44665a99e5cf43718.