From: Danny Milosavljevic <dannym@scratchpost.org>
To: Ivan Petkov <ivanppetkov@gmail.com>
Cc: Chris Marusich <cmmarusich@gmail.com>, 35155@debbugs.gnu.org
Subject: [bug#35155] [PATCH] build-system/cargo: refactor phases to successfully build
Date: Sat, 6 Apr 2019 12:32:34 +0200 [thread overview]
Message-ID: <20190406123234.3b687936@scratchpost.org> (raw)
In-Reply-To: <D2627D15-4627-4361-A8C3-ADA412B6CCCF@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
Hi Ivan,
good idea.
(Finally the hack with the Cargo.lock is gone :) )
>There are many system specific
> package in crates.io (e.g. for Windows, Redox, Fuschia, WASM, etc.) and
> attempting to keep up with what crates must be patched out is futile.
I agree.
> * The build phases will honor a skip-build? flag which allows for
> short-circuiting for optional packages which require nightly features or cannot
> be built for the current platform.
Ok, I guess.
> Changes which still need to be done:
> * Update the host-side code to expand transitive inputs: cargo requires that
> all transitive crate dependencies are present in its (vendored) index, but
> doing so by hand in the package definitions will become unwieldy.
Yeah. Let's do that in an extra patch.
> * Update the host-side code to detect any "circular" dependencies which can
> result from a naive import
Yeah.
> Unfortunately there isn't a good way to test this patch at the moment.
> Importing a non-trivial crate requires a lot of manual resolution, especially
> with the points above remaining unimplemented.
> If someone would really like to see the input package definitions I was using
> to test, I'd be happy to share, though I'd advise that it's pretty hacked up
> for my own convoluted testing at the moment.
No, I can use my own set of hacked-together package definition to test it.
(The state of my hacked-together package definitions is not good enough to merge :) )
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-06 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 7:07 [bug#35155] [PATCH] build-system/cargo: refactor phases to successfully build Ivan Petkov
2019-04-06 10:32 ` Danny Milosavljevic [this message]
2019-04-06 10:41 ` Danny Milosavljevic
2019-04-06 16:12 ` Ivan Petkov
2019-04-06 23:27 ` Chris Marusich
2019-04-07 2:02 ` Ivan Petkov
2019-04-07 3:05 ` Ivan Petkov
2019-04-07 8:40 ` Chris Marusich
2019-04-07 15:49 ` Ivan Petkov
[not found] ` <87mukz8p3g.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me>
2019-04-09 16:01 ` bug#35155: " Ivan Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406123234.3b687936@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35155@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
--cc=ivanppetkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).