unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Yoshinori Arai <kumagusu08@gmail.com>
Cc: Eric Bavier <ericbavier@centurylink.net>, 34262-done@debbugs.gnu.org
Subject: bug#34262: [PATCH]Add: nkf
Date: Mon, 25 Feb 2019 23:17:51 -0500	[thread overview]
Message-ID: <20190226041751.GA15689@jasmine.lan> (raw)
In-Reply-To: <20190201040305.luu56jkwndye2zrv@WaraToNora>

[-- Attachment #1: Type: text/plain, Size: 2695 bytes --]

> From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001
> From: Yoshinori Arai <kumagusu08@gmail.com>
> Date: Fri, 1 Feb 2019 12:55:46 +0900
> Subject: [PATCH] Add nkf
> 
> ---
>  gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)

Thank you!

I made the changes shown below and pushed as
933ac939d6d2de64c43e068e7c0ebfaaaf2dcdd8

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 2d3a090056..71f03b7568 100644
  1 gnu: Add nkf.
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -800,14 +800,16 @@ Mainland China, Taiwan, and Hong-Kong.")
         (revision "1"))
     (package
       (name "nkf")
-      ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/
+      ;; The commits corresponding to specific versions are published
+      ;; here:
+      ;; https://ja.osdn.net/projects/nkf/scm/git/nkf/
       (version "2.1.5")
       (source (origin
                 (method git-fetch)
                 (uri (git-reference
                       (url "https://github.com/nurse/nkf.git")
                       (commit commit)))
-                (file-name (string-append name version))
+                (file-name (git-file-name name version))
                 (sha256
                  (base32
                   "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
@@ -815,21 +817,11 @@ Mainland China, Taiwan, and Hong-Kong.")
       (arguments
        `(#:tests? #f ; test for perl module
          #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
-                            (string-append "prefix=" %output))
+                            (string-append "prefix=" %output)
+                            "MKDIR=mkdir -p")
          #:phases
          (modify-phases %standard-phases
-           (delete 'configure)
-           ;; mkdir can't create directory
-           (replace 'install
-             (lambda* (#:key outputs #:allow-other-keys)
-               (let* ((out (assoc-ref outputs "out"))
-                      (bin (string-append out "/bin"))
-                      (man1 (string-append out "/share/man/man1"))
-                      (man1j (string-append out "/share/man/ja/man1")))
-                 (install-file "nkf" bin)
-                 (install-file "nkf.1" man1)
-                 (install-file "nkf.1j" man1j)
-                 #t))))))
+           (delete 'configure)))) ; No ./configure script
       (home-page "https://ja.osdn.net/projects/nkf/")
       (synopsis "Network Kanji Filter")
       (description "Nkf is yet another kanji code converter among networks,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2019-02-26  4:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  6:43 [bug#34262] [PATCH]Add: nkf Yoshinori Arai
2019-01-31 14:55 ` Eric Bavier
2019-02-01  4:03   ` Yoshinori Arai
2019-02-26  4:17     ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226041751.GA15689@jasmine.lan \
    --to=leo@famulari.name \
    --cc=34262-done@debbugs.gnu.org \
    --cc=ericbavier@centurylink.net \
    --cc=kumagusu08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).