From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvwy5-0001fz-0T for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvwxx-00049b-0V for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvwxt-00048F-AX for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gvwxq-0000A0-JX for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:05 -0500 Subject: [bug#34515] [PATCH 10/13] gnu: Add python-autobahn. Resent-Message-ID: Date: Mon, 18 Feb 2019 23:23:49 -0500 From: Leo Famulari Message-ID: <20190219042349.GD2718@jasmine.lan> References: <44e542e83121ab7fe02f134d349fbb484396ce30.1550437064.git.leo@famulari.name> <87wolxwlfd.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UoPmpPX/dBe4BELn" Content-Disposition: inline In-Reply-To: <87wolxwlfd.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34515@debbugs.gnu.org --UoPmpPX/dBe4BELn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 18, 2019 at 09:27:50AM +0100, Ricardo Wurmus wrote: > Leo Famulari writes: > > * gnu/packages/python-web.scm (python-autobahn): New variable. > [=E2=80=A6] > > + (arguments > > + `(#:tests? #f)) ; fail mysteriously >=20 > Mysteriously, eh? Do you have any more information about this that > might help us debug this? Basically, the tests quit early after several errors like this: ------ ______ ERROR collecting build/lib/autobahn/nvx/test/test_utf8validator.py _= _____ import file mismatch: imported module 'test_utf8validator' has this __file__ attribute: /tmp/guix-build-python-autobahn-19.2.1.drv-0/autobahn-19.2.1/autobahn/nvx= /test/test_utf8validator.py which is not the same as the test file we want to collect: /tmp/guix-build-python-autobahn-19.2.1.drv-0/autobahn-19.2.1/build/lib/au= tobahn/nvx/test/test_utf8validator.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your= test file modules ------ I don't fully understand the issue but it's discussed in the pytest bug tracker as a general issue: https://github.com/pytest-dev/pytest/issues/529 What do you think? My opinion is that the test suite is broken. The failure can be reproduced by adding this patch: diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm index c58f358c63..e4ca630498 100644 --- a/gnu/packages/python-web.scm +++ b/gnu/packages/python-web.scm @@ -3014,7 +3014,23 @@ high level API for making HTTP requests when using T= wisted.") "1mm7j24ls01c7jb1ad5p5cpyxvzgydiyf8b04ihykh2v8g98j0x7")))) (build-system python-build-system) (arguments - `(#:tests? #f)) ; fail mysteriously + `(#:tests? #t + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'adjust-tests + (lambda _ + ;; This variable chooses whether to use Twisted or + ;; asyncio for the tests. + (setenv "USE_TWISTED" "true") + ;; The require an old pytest because they aim to support + ;; Python 3.3. + (substitute* "setup.py" + (("pytest>=3D2.8.6,<3.3.0") + "pytest")) + #t))))) + (native-inputs + `(("python-mock" ,python-mock) + ("python-pytest" ,python-pytest))) (propagated-inputs `(("python-cffi" ,python-cffi) ("python-twisted" ,python-twisted) --UoPmpPX/dBe4BELn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlxrhNUACgkQJkb6MLrK fwiLhg//dPAQplzGszvZtxZpllUYBEpowUvyOygo13HX2P5iTolrmknhOtFE36Z3 qK4wR+wNd9s7G9a7uk49vSLkGQWCuW2OuFA0R44aVwOXA5P0ix5ewSOBo4My/k5F QAA3ukGfhgx0H1DXBAu0hgbmN2Pap/YSpJH1ySQL5cHpXws4oJoNQZu8XuEXm04i 2FM8SgGThUCZjoythoQ9WHGOHaGhG+caOs/Ie1mLR64ebtf9vC09JdczXyjH0mqq ojZGIaKIM+1fVvsiedJZBff7/IsXWild7s0Kv1LviU0+v4w0AvCksMa7KYSRHOdH mqOQIRK/pU9gVIGuU6BgSayLk3O3X2Mvb6iTJ3KhP2MO+TGEmIcHsHSWO+w1BZJl rHqtBBjun8h5i6USCyXJcbDE6XkilYM7f1QgLyApeO3ZiDn/vW58oe6S7yA2KT2B SOIN50zqbhmrW/sulcVXV2wh8yyBL9AgOnrG8b1jFPHW4gWoefmYB4/KxvKPEa1O OrKwVcBtxj843+zU8g0XxGGoxqphH1DWqfA1AEEd2FhhCKLpeAd5vXleCpf7z0oN 6IJS8uFiTI2Zh2HM5aA6y98jT+d0FGczUigSzQMkt6CBvvBX1x144K9sXarysl2j E5kPLQJC0NR48tiO7wavGfDOIyPtUrwaRLkabJ6jmv9zgi3uQPM= =pxPW -----END PGP SIGNATURE----- --UoPmpPX/dBe4BELn--