unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 34385@debbugs.gnu.org
Subject: [bug#34385] [PATCH v2 3/3] guix: ruby-build-system: Fix removal of extension related files.
Date: Wed, 13 Feb 2019 21:48:49 +0100	[thread overview]
Message-ID: <20190213214849.627f4121@alma-ubu> (raw)
In-Reply-To: <20190208195642.4057-3-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On Fri,  8 Feb 2019 19:56:42 +0000
Christopher Baines <mail@cbaines.net> wrote:

> This functionality was broken, possibly to do with the vendor related
> changes in the ruby build system. These changes restore the file
> removal functionality at the end of the install phase.
> 
> * guix/build/ruby-build-system.scm (install): Fix removal of files
> related to native extensions.

LGTM.

In particular, the ruby-idn-ruby package is now reproducible.

Thanks,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2019-02-13 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 10:24 [bug#34385] [PATCH 0/2] Ruby build system improvements Christopher Baines
2019-02-08 10:35 ` [bug#34385] [PATCH 1/2] gnu: ruby-build-system: Change extract-gemspec to always return #t Christopher Baines
2019-02-08 10:35   ` [bug#34385] [PATCH 2/2] guix: ruby-build-system: Do gem install --verbose Christopher Baines
2019-02-08 19:56 ` [bug#34385] [PATCH v2 1/3] gnu: ruby-build-system: Change extract-gemspec to always return #t Christopher Baines
2019-02-08 19:56   ` [bug#34385] [PATCH v2 2/3] guix: ruby-build-system: Do gem install --verbose Christopher Baines
2019-02-13 20:47     ` Björn Höfling
2019-02-08 19:56   ` [bug#34385] [PATCH v2 3/3] guix: ruby-build-system: Fix removal of extension related files Christopher Baines
2019-02-13 20:48     ` Björn Höfling [this message]
2019-02-14 19:30       ` bug#34385: " Christopher Baines
2019-02-13 20:46   ` [bug#34385] [PATCH v2 1/3] gnu: ruby-build-system: Change extract-gemspec to always return #t Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213214849.627f4121@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=34385@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).