From: Danny Milosavljevic <dannym@scratchpost.org>
To: Leo Famulari <leo@famulari.name>
Cc: 34446@debbugs.gnu.org
Subject: [bug#34446] Runc container escape patches CVE-2019-5736
Date: Tue, 12 Feb 2019 01:10:34 +0100 [thread overview]
Message-ID: <20190212011034.1dd00e4c@scratchpost.org> (raw)
In-Reply-To: <20190211233708.GA2509@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
Hi Leo,
as originally released by upstream, Docker looks up auxiliary commands in PATH,
using a Go function called "LookPath".
Our package definition patches a lot of the specific LookPath calls to
refer to inputs by absolute path.
I've booby-trapped the remaining LookPath calls so we won't accidentially
have an internal tool looked up in $PATH.
If we have not forgotten any LookPath calls, there should have been no remaining
LookPath calls and it would not have failed the build.
> .gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/iptables/iptables.go:90:15: undefined: exec.Guix_doesnt_want_LookPath
> .gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/iptables/iptables.go:90:45: invalid character U+005C '\'
Please examine line 90. It probably has a LookPath line with a new argument we
haven't seen before.
That means we'd have to find out which Guix package has an executable named like
the argument and add a case to the existing LookPath substituter in order to
also substitute it.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-12 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 23:37 [bug#34446] Runc container escape patches CVE-2019-5736 Leo Famulari
2019-02-12 0:10 ` Danny Milosavljevic [this message]
2019-02-12 0:13 ` Danny Milosavljevic
2019-02-12 17:56 ` bug#34446: " Leo Famulari
2019-02-12 0:27 ` [bug#34446] [PATCH 1/2] gnu: runc: Update to 1.0.0-rc6 [fixes CVE-2019-5736] Leo Famulari
2019-02-12 0:27 ` [bug#34446] [PATCH 2/2] gnu: Docker: Update to 18.09.2 Leo Famulari
2019-02-12 0:45 ` [bug#34446] [PATCH 1/2] gnu: runc: Update to 1.0.0-rc6 [fixes CVE-2019-5736] Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212011034.1dd00e4c@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=34446@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).