unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 34217@debbugs.gnu.org
Subject: [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire.
Date: Sun, 3 Feb 2019 22:03:39 +0100	[thread overview]
Message-ID: <20190203220328.747b1454@alma-ubu> (raw)
In-Reply-To: <20190127114956.26570-1-mail@cbaines.net>

On Sun, 27 Jan 2019 11:49:46 +0000
Christopher Baines <mail@cbaines.net> wrote:

> Package version 0.0.1 initially, as this is what's needed by Cucumber
> 3, and Cucumber 4 hasn't been released yet.

I would prefer to see this hint as a comment in the code, not in the
commit message: When I as a developer stumble upon the package
definition and see it is outdated, I would just update it and not
search all commit messages to find out it shouldn't. A comment near the
package definition or version would prevent that mistake.

Otherwise, LGTM.

Thanks,

Björn

  parent reply	other threads:[~2019-02-03 21:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-27 11:06 [bug#34217] [PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates Christopher Baines
2019-01-27 11:49 ` [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 02/11] gnu: Add ruby-contracts Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 03/11] gnu: Add ruby-ruby-progressbar Christopher Baines
2019-02-03 21:40     ` Björn Höfling
2019-02-08 18:58       ` Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 04/11] gnu: Add ruby-fuubar Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 05/11] gnu: Add ruby-cucumber-expressions Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 06/11] gnu: Add ruby-mspec Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 07/11] gnu: Add ruby-backports Christopher Baines
2019-01-31  8:53     ` swedebugia
2019-02-01 15:41       ` swedebugia
2019-02-08 19:10         ` Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 08/11] gnu: Add ruby-cucumber-tag-expressions Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 09/11] gnu: ruby-cucumber-core: Update to 3.2.1 Christopher Baines
2019-02-03 22:20     ` Björn Höfling
2019-02-08 18:48       ` Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 10/11] gnu: ruby-gherkin: Update to 5.1.0 Christopher Baines
2019-01-27 11:49   ` [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba Christopher Baines
2019-01-29 21:44     ` swedebugia
2019-01-30 12:56       ` Ricardo Wurmus
2019-01-30 16:11         ` swedebugia
2019-01-30 16:22           ` swedebugia
2019-01-31  8:43             ` swedebugia
2019-02-08 18:46               ` Christopher Baines
2019-02-03 22:18     ` Björn Höfling
2019-02-03 23:26       ` Ricardo Wurmus
2019-02-08 17:19         ` Christopher Baines
2019-02-08 17:19       ` Christopher Baines
2019-02-08 19:02         ` Björn Höfling
2019-02-03 21:03   ` Björn Höfling [this message]
2019-02-08 19:05     ` [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire Christopher Baines
2019-01-28  5:52 ` [bug#34217] [PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates swedebugia
2019-02-03 22:21 ` Björn Höfling
2019-02-14 21:57 ` bug#34217: Ruby on Rails Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190203220328.747b1454@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=34217@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).