From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnnve-0004xj-AJ for guix-patches@gnu.org; Sun, 27 Jan 2019 12:09:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnnvd-0006QL-7f for guix-patches@gnu.org; Sun, 27 Jan 2019 12:09:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48533) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnnvd-0006Q6-3y for guix-patches@gnu.org; Sun, 27 Jan 2019 12:09:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnnvc-0001ms-Tw for guix-patches@gnu.org; Sun, 27 Jan 2019 12:09:04 -0500 Subject: [bug#34222] [PATCH 01/15] gnu: ruby-rspec-its: Enable tests. Resent-Message-ID: From: Christopher Baines Date: Sun, 27 Jan 2019 17:08:06 +0000 Message-Id: <20190127170820.28937-1-mail@cbaines.net> In-Reply-To: <87y376ghl0.fsf@cbaines.net> References: <87y376ghl0.fsf@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 34222@debbugs.gnu.org Enable the tests, and also tweak the synopsis and description to hopefully be more descriptive. * gnu/packages/ruby.scm (ruby-rspec-its)[source]: Change to GitHub, and add patch. [arguments]: Enabled tests, set the #:test-target to "spec", and add the phases to tweak the Gemfile and rspec-its.gemspec. [native-inputs]: Add bundler, ruby-cucumber and ruby-aruba. [synopsis,description]: Make more explicit and descriptive. --- gnu/packages/ruby.scm | 49 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 59895240f8..b0cf9feb02 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -392,20 +392,55 @@ outcomes of a code example.") (version "1.2.0") (source (origin - (method url-fetch) - (uri (rubygems-uri "rspec-its" version)) + (method git-fetch) + (uri (git-reference + (url "https://github.com/rspec/rspec-its.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 - "1pwphny5jawcm1hda3vs9pjv1cybaxy17dc1s75qd7drrvx697p3")))) + "190rz7v4q4wk80fzhr5hknvxx4vb2pywmqr8wc41w2blj9ylzi0f")) + (patches + (list + (origin (method url-fetch) + (uri (string-append + "https://github.com/rspec/rspec-its/commit/" + "bfaab439c7c879f5ef25552f41827891f6308373.patch")) + (file-name "ruby-rspec-its-fix-specs-for-ruby-2.4.patch") + (sha256 + (base32 + "0lnik0kvrpgkakvdb2fmzg22pdlraf6kiidr9sv6rnfyviiqwxgh"))))))) (build-system ruby-build-system) (arguments - `(#:tests? #f)) ; needs cucumber. + `(#:test-target "spec" + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'dont-install-gems-from-gemfile + (lambda _ + (substitute* "Gemfile" + (("rspec rspec-core rspec-expectations rspec-mocks rspec-support") + "")) + #t)) + (add-before 'build 'remove-unnecessary-dependency-versions-from-gemfile + (lambda _ + (substitute* "rspec-its.gemspec" + (("rake.*") "rake'\n") + (("cucumber.*") "cucumber'\n") + (("bundler.*") "bundler'\n") + (("aruba.*") "aruba'\n")) + #t))))) (propagated-inputs `(("ruby-rspec-core" ,ruby-rspec-core) ("ruby-rspec-expectations" ,ruby-rspec-expectations))) - (synopsis "RSpec extension gem for attribute matching") - (description "@code{rspec-its} is an RSpec extension gem for attribute -matching.") + (native-inputs + `(("bundler" ,bundler) + ("ruby-cucumber" ,ruby-cucumber) + ("ruby-aruba" ,ruby-aruba))) + (synopsis "RSpec extension that provides the @code{its} method") + (description + "RSpec::Its provides the its method as a short-hand to specify the expected +value of an attribute. For example, one can use @code{its(:size)\\{should +eq(1)\\}}.") (home-page "https://github.com/rspec/rspec-its") (license license:expat))) -- 2.20.1