From: Christopher Baines <mail@cbaines.net>
To: 34222@debbugs.gnu.org
Subject: [bug#34222] [PATCH 01/15] gnu: ruby-rspec-its: Enable tests.
Date: Sun, 27 Jan 2019 17:08:06 +0000 [thread overview]
Message-ID: <20190127170820.28937-1-mail@cbaines.net> (raw)
In-Reply-To: <87y376ghl0.fsf@cbaines.net>
Enable the tests, and also tweak the synopsis and description to hopefully be
more descriptive.
* gnu/packages/ruby.scm (ruby-rspec-its)[source]: Change to GitHub, and add
patch.
[arguments]: Enabled tests, set the #:test-target to "spec", and add the
phases to tweak the Gemfile and rspec-its.gemspec.
[native-inputs]: Add bundler, ruby-cucumber and ruby-aruba.
[synopsis,description]: Make more explicit and descriptive.
---
gnu/packages/ruby.scm | 49 ++++++++++++++++++++++++++++++++++++-------
1 file changed, 42 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 59895240f8..b0cf9feb02 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -392,20 +392,55 @@ outcomes of a code example.")
(version "1.2.0")
(source
(origin
- (method url-fetch)
- (uri (rubygems-uri "rspec-its" version))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/rspec/rspec-its.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
(sha256
(base32
- "1pwphny5jawcm1hda3vs9pjv1cybaxy17dc1s75qd7drrvx697p3"))))
+ "190rz7v4q4wk80fzhr5hknvxx4vb2pywmqr8wc41w2blj9ylzi0f"))
+ (patches
+ (list
+ (origin (method url-fetch)
+ (uri (string-append
+ "https://github.com/rspec/rspec-its/commit/"
+ "bfaab439c7c879f5ef25552f41827891f6308373.patch"))
+ (file-name "ruby-rspec-its-fix-specs-for-ruby-2.4.patch")
+ (sha256
+ (base32
+ "0lnik0kvrpgkakvdb2fmzg22pdlraf6kiidr9sv6rnfyviiqwxgh")))))))
(build-system ruby-build-system)
(arguments
- `(#:tests? #f)) ; needs cucumber.
+ `(#:test-target "spec"
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'dont-install-gems-from-gemfile
+ (lambda _
+ (substitute* "Gemfile"
+ (("rspec rspec-core rspec-expectations rspec-mocks rspec-support")
+ ""))
+ #t))
+ (add-before 'build 'remove-unnecessary-dependency-versions-from-gemfile
+ (lambda _
+ (substitute* "rspec-its.gemspec"
+ (("rake.*") "rake'\n")
+ (("cucumber.*") "cucumber'\n")
+ (("bundler.*") "bundler'\n")
+ (("aruba.*") "aruba'\n"))
+ #t)))))
(propagated-inputs
`(("ruby-rspec-core" ,ruby-rspec-core)
("ruby-rspec-expectations" ,ruby-rspec-expectations)))
- (synopsis "RSpec extension gem for attribute matching")
- (description "@code{rspec-its} is an RSpec extension gem for attribute
-matching.")
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-cucumber" ,ruby-cucumber)
+ ("ruby-aruba" ,ruby-aruba)))
+ (synopsis "RSpec extension that provides the @code{its} method")
+ (description
+ "RSpec::Its provides the its method as a short-hand to specify the expected
+value of an attribute. For example, one can use @code{its(:size)\\{should
+eq(1)\\}}.")
(home-page "https://github.com/rspec/rspec-its")
(license license:expat)))
--
2.20.1
next prev parent reply other threads:[~2019-01-27 17:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 17:01 [bug#34222] [PATCH 00/15] Add ruby-rubocop and dependencies Christopher Baines
2019-01-27 17:08 ` Christopher Baines [this message]
2019-01-27 17:08 ` [bug#34222] [PATCH 02/15] gnu: Add ruby-powerpack Christopher Baines
2019-01-27 17:44 ` Ricardo Wurmus
2019-01-27 18:44 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 03/15] gnu: Add ruby-rainbow Christopher Baines
2019-01-27 17:25 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 04/15] gnu: Add ruby-racc Christopher Baines
2019-01-27 17:27 ` Ricardo Wurmus
2019-01-27 18:57 ` Christopher Baines
2019-01-27 19:06 ` Christopher Baines
2019-01-27 19:26 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 05/15] gnu: Add ruby-hashdiff Christopher Baines
2019-01-27 17:45 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 06/15] gnu: Add ruby-crack Christopher Baines
2019-01-27 17:29 ` Ricardo Wurmus
2019-01-27 18:55 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 07/15] gnu: Add ruby-webmock Christopher Baines
2019-01-27 17:32 ` Ricardo Wurmus
2019-01-27 18:53 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 08/15] gnu: Add ruby-rest-client Christopher Baines
2019-01-27 17:34 ` Ricardo Wurmus
2019-01-27 18:51 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 09/15] gnu: Add ruby-bacon-colored-output Christopher Baines
2019-01-27 17:34 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 10/15] gnu: Add ruby-ast Christopher Baines
2019-01-27 17:36 ` Ricardo Wurmus
2019-01-27 18:50 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 11/15] gnu: Add ruby-cliver Christopher Baines
2019-01-27 17:38 ` Ricardo Wurmus
2019-01-27 18:48 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 12/15] gnu: Add ruby-parser Christopher Baines
2019-01-27 17:39 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 13/15] gnu: Add ruby-unicode-display-width Christopher Baines
2019-01-27 17:39 ` Ricardo Wurmus
2019-01-27 17:08 ` [bug#34222] [PATCH 14/15] gnu: Add ruby-jaro-winkler Christopher Baines
2019-01-27 17:40 ` Ricardo Wurmus
2019-01-27 18:45 ` Christopher Baines
2019-01-27 17:08 ` [bug#34222] [PATCH 15/15] gnu: Add ruby-rubocop Christopher Baines
2019-01-27 17:41 ` Ricardo Wurmus
2019-01-27 17:20 ` [bug#34222] [PATCH 01/15] gnu: ruby-rspec-its: Enable tests Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127170820.28937-1-mail@cbaines.net \
--to=mail@cbaines.net \
--cc=34222@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).