From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giiYN-0003l3-76 for guix-patches@gnu.org; Sun, 13 Jan 2019 11:24:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giiYM-00084w-En for guix-patches@gnu.org; Sun, 13 Jan 2019 11:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giiYM-00084j-8Z for guix-patches@gnu.org; Sun, 13 Jan 2019 11:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giiYM-0000mF-06 for guix-patches@gnu.org; Sun, 13 Jan 2019 11:24:02 -0500 Subject: [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags. Resent-Message-ID: Date: Sun, 13 Jan 2019 10:23:20 -0600 From: Eric Bavier Message-ID: <20190113102320.543cba28@centurylink.net> In-Reply-To: <20190113074859.GB2050@macbook41> References: <20190113071850.14337-1-ericbavier@centurylink.net> <20190113074859.GB2050@macbook41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/UWI5vYBAeZ.Mio42RpUUOLl"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 34056@debbugs.gnu.org, Eric Bavier --Sig_/UWI5vYBAeZ.Mio42RpUUOLl Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 13 Jan 2019 09:48:59 +0200 Efraim Flashner wrote: > On Sun, Jan 13, 2019 at 01:18:49AM -0600, ericbavier@centurylink.net wrot= e: > > From: Eric Bavier > >=20 > > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' -> > > 'TESTOPTS'. This overrides the default '-l' argument for memory leak c= hecks > > which is not compatible with the -j for parallelism. > > --- > > gnu/packages/python.scm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > index 9b43f465cc..dffded738d 100644 > > --- a/gnu/packages/python.scm > > +++ b/gnu/packages/python.scm > > @@ -194,7 +194,7 @@ > > (assoc-ref %outputs "out") "/lib")) > > ;; With no -j argument tests use all available cpus, so provide= one. > > #:make-flags > > - (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-count))) > > + (list (format #f "TESTOPTS=3D-j~d" (parallel-job-count))) > > =20 > > #:modules ((ice-9 ftw) (ice-9 match) > > (guix build utils) (guix build gnu-build-system)) > > --=20 > > 2.20.1 > > =20 >=20 > I'm building out python2 now on my aarch64 board but I assume it'll > work. While I do prefer the parallelism in the test suite, between the > two I'd consider the memory leak checks the more important of the two. >=20 Are the memory-leak checks something that we need to worry about in our packaging of python2? Can memory leaks be introduced in the way we configure and build our python? Otherwise I assume that's something more interesting to someone developing python itself and not as interesting in system CI. IMHO. I see I should probably move the comment about this overriding -l from the commit message to the code comment. `~Eric --Sig_/UWI5vYBAeZ.Mio42RpUUOLl Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlw7ZfgACgkQ/XPKxxnT JWaHzw/7BHtgXNhjZanqCInPisZFGyFvAy1WSp+83iQgg5OtsjNm3R8M6W0fRCYH 9ZqC7jYddM52T/Etpv+RCSAfLLZVx2/9anGYMeZ49PjQUcJFm1PTodtotsrJhIFZ N4xcMA/zMshAne4HlvAwd93YdAYTMGHzinPl9wacZUM8IrxhZHlN394qcd63Y4hc pJvNkDYm/Kh0QQANRMPZoL/BBk8aGGC4A5+HcpCXZBP3Oe5G//DrdxZTmILXZMmp kLnMApRiNW0x10WNniCcq2EfUO9aqWr9pGa4nhc2FTEDGRbXxTXEmTVoe8gQaurY WKVlB08JuTdN57jFf5+Ubs8EKzKiFJAYbmBGi9GPnqwrVr8v3gkgoNEfzZgPJY/V YeszSk+ZfQB6xNkzbe6QTKl0ej9oCvcahPVUJOKXP0Sab2ki4kq8heGIQUHntTzs t8DpxEfMHef+hhC0jomOd28F9E6FC2N5QzGAwkhOt2UI+krcE/IErvMLPELgBAhJ Vs/jZgY0rm9PSP7lsio79iVQVLfbMDEqdd5E4vKB5XsAzoPB8+sekdFhHTH2iXkY eO8Qvlj7UiHquVB9YrsHx6XsTgvV97Hf2QoPzjS4lBEqMPHRFwCm2wAxWy8VfgpX PQ6n/4xduZ01LjLFFXLsr0NVzK/DkMlQu5nwvOONDmNczwgaNtE= =JnpZ -----END PGP SIGNATURE----- --Sig_/UWI5vYBAeZ.Mio42RpUUOLl--