unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: ericbavier@centurylink.net
Cc: 34056@debbugs.gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags.
Date: Sun, 13 Jan 2019 09:48:59 +0200	[thread overview]
Message-ID: <20190113074859.GB2050@macbook41> (raw)
In-Reply-To: <20190113071850.14337-1-ericbavier@centurylink.net>

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

On Sun, Jan 13, 2019 at 01:18:49AM -0600, ericbavier@centurylink.net wrote:
> From: Eric Bavier <bavier@member.fsf.org>
> 
> * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' ->
> 'TESTOPTS'.  This overrides the default '-l' argument for memory leak checks
> which is not compatible with the -j for parallelism.
> ---
>  gnu/packages/python.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9b43f465cc..dffded738d 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -194,7 +194,7 @@
>                              (assoc-ref %outputs "out") "/lib"))
>         ;; With no -j argument tests use all available cpus, so provide one.
>         #:make-flags
> -       (list (format #f "EXTRATESTOPTS=-j~d" (parallel-job-count)))
> +       (list (format #f "TESTOPTS=-j~d" (parallel-job-count)))
>  
>          #:modules ((ice-9 ftw) (ice-9 match)
>                     (guix build utils) (guix build gnu-build-system))
> -- 
> 2.20.1
> 

I'm building out python2 now on my aarch64 board but I assume it'll
work. While I do prefer the parallelism in the test suite, between the
two I'd consider the memory leak checks the more important of the two.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2019-01-13  7:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13  7:18 [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags ericbavier
2019-01-13  7:18 ` [bug#34057] [PATCH] core-updates -- gnu: groff: Fix doc installation ericbavier
2019-01-14 21:36   ` bug#34057: " Eric Bavier
2019-01-13  7:48 ` Efraim Flashner [this message]
2019-01-13 16:23   ` [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags Eric Bavier
2019-01-13 17:16     ` Efraim Flashner
2019-01-13 22:56 ` Christopher Baines
2019-01-14  2:42   ` Eric Bavier
2019-01-21 19:10     ` Christopher Baines
2019-01-22  1:16       ` Eric Bavier
2019-01-23  4:05         ` bug#34056: " Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190113074859.GB2050@macbook41 \
    --to=efraim@flashner.co.il \
    --cc=34056@debbugs.gnu.org \
    --cc=bavier@member.fsf.org \
    --cc=ericbavier@centurylink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).