From: Rutger Helling <rhelling@mykolab.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33902-done@debbugs.gnu.org
Subject: bug#33902: [PATCH] gnu: Add wlstream.
Date: Thu, 10 Jan 2019 08:57:16 +0100 [thread overview]
Message-ID: <20190110075716.51f992ad@mykolab.com> (raw)
In-Reply-To: <874lah7s9g.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
Thanks for the review, pushed with fixed indentation.
I'll make sure to double check with ./etc/indent-code.el from now on.
On Wed, 09 Jan 2019 16:41:31 +0100
Ludovic Courtès <ludo@gnu.org> wrote:
> Hello Rutger,
>
> Rutger Helling <rhelling@mykolab.com> skribis:
>
> > From b38bdecd0dee379f50241092aab2be4b69606209 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling@mykolab.com>
> > Date: Fri, 28 Dec 2018 20:15:22 +0100
> > Subject: [PATCH 1/2] gnu: ffmpeg: Add libdrm support.
> >
> > * gnu/packages/video.scm (ffmpeg): Add libdrm support.
>
> [...]
>
> > From 5d18a851060605deee53c275159a6d37bfc0b007 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling@mykolab.com>
> > Date: Sat, 29 Dec 2018 16:17:59 +0100
> > Subject: [PATCH 2/2] gnu: Add wlstream.
> >
> > * gnu/packages/video.scm (wlstream): New variable.
>
> Both LGTM!
>
> > +(define-public wlstream
> > + (let ((commit "182076a94562b128c3a97ecc53cc68905ea86838")
> > + (revision "1"))
> > + (package
> > + (name "wlstream")
> ^
>
> We usually add an extra space here. Did you try running
> ./etc/indent-code.el on your packages? Or is it too inconvenient?
>
> Thanks,
> Ludo’.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-10 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:46 [bug#33902] [PATCH] gnu: Add wlstream Rutger Helling
2018-12-29 14:38 ` Brendan Tildesley
2018-12-29 21:43 ` Rutger Helling
2019-01-09 15:41 ` Ludovic Courtès
2019-01-10 7:57 ` Rutger Helling [this message]
2019-01-10 8:54 ` Ludovic Courtès
2019-01-11 9:25 ` Rutger Helling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110075716.51f992ad@mykolab.com \
--to=rhelling@mykolab.com \
--cc=33902-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).