unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: 33759@debbugs.gnu.org
Subject: [bug#33759] [PATCH v2 4/5] gnu: python-futures: Enable tests.
Date: Thu,  3 Jan 2019 21:34:51 +0000	[thread overview]
Message-ID: <20190103213452.1829-4-mail@cbaines.net> (raw)
In-Reply-To: <20190103213452.1829-1-mail@cbaines.net>

Re-enable the tests, as the python-2 package now has the support
directory. Also, switch to running the tests via the test_futures.py script to
avoid errors like:

  AttributeError: 'AsCompletedTests' object has no attribute 'executor'

* gnu/packages/python.scm (python2-futures)[arguments]: Run the
test_futures.py script to run the tests.
---
 gnu/packages/python.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 550643adb8..54bc1d4d02 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -7918,11 +7918,14 @@ otherwise matches 3.2’s API.")
          (base32
           "0rdjmmsab550kxsssdq49jcniz77zlkpw4pvi9hvib3lsskjmh4y"))))
     (build-system python-build-system)
-    (arguments `(#:python ,python-2
-                 ;; FIXME: Python 2.7.14 moved the test.support library,
-                 ;; but our package has not yet been adjusted.  Enable
-                 ;; tests when the python2 package has been fixed.
-                 #:tests? #f))
+    (arguments
+     `(#:python ,python-2
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "python" "test_futures.py")
+             #t)))))
     (home-page "https://github.com/agronholm/pythonfutures")
     (synopsis
      "Backport of the concurrent.futures package from Python 3.2")
-- 
2.20.1

  parent reply	other threads:[~2019-01-03 21:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15 12:17 [bug#33759] [PATCH] gnu: linkchecker: Fix build Christopher Baines
2018-12-16 15:12 ` Ludovic Courtès
2019-01-01 22:57   ` Christopher Baines
2019-01-03 21:34 ` [bug#33759] [PATCH v2 1/5] " Christopher Baines
2019-01-03 21:34   ` [bug#33759] [PATCH v2 2/5] gnu: Add python-miniboa Christopher Baines
2019-01-03 21:34   ` [bug#33759] [PATCH v2 3/5] gnu: python-2.7: Include /lib/python.../test/support Christopher Baines
2019-01-03 21:34   ` Christopher Baines [this message]
2019-01-03 21:34   ` [bug#33759] [PATCH v2 5/5] gnu: linkchecker: Fix the package building Christopher Baines
2019-01-25 22:14 ` [bug#33759] [PATCH] gnu: linkchecker: Fix build Christopher Baines
2019-10-08 18:36   ` bug#33759: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103213452.1829-4-mail@cbaines.net \
    --to=mail@cbaines.net \
    --cc=33759@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).