unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 33955@debbugs.gnu.org
Subject: [bug#33955] [PATCH 2/6] gnu: kirigami: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:46 +0100	[thread overview]
Message-ID: <20190102184650.8075-2-h.goebel@crazy-compilers.com> (raw)
In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com>

The error which inhibited running the tests no longer occurs
in 5.49.0, although now no tests are found at all.  Since no tests
are found now, the phase 'check-setup can be removed, too,
and thus the 'arguments' at all.

* gnu/packages/kde-frameworks.scm(kirigami)[arguments]: Remove.
---
 gnu/packages/kde-frameworks.scm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 35e10015e..62cf49c57 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -804,19 +804,6 @@ or user activity.")
        ("qtsvg" ,qtsvg)
        ;; Run-time dependency
        ("qtgraphicaleffects" ,qtgraphicaleffects)))
-    (arguments
-     `(#:tests? #f ;; FIXME: Test suite is broken,
-       ;; see https://bugs.kde.org/show_bug.cgi?id=386456
-       ;; Note for when enabling the tests: The test-suite is meant to be run
-       ;; without prior installation, see
-       ;; https://cgit.kde.org/kirigami.git/commit/?id=24ad2c9
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'check-setup
-           (lambda* (#:key outputs #:allow-other-keys)
-             ;; make Qt render "offscreen", required for tests
-             (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "QtQuick components for mobile user interfaces")
     (description "Kirigami is a set of high level QtQuick components looking
-- 
2.13.7

  reply	other threads:[~2019-01-02 18:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 18:45 [bug#33955] [PATCH 0/6] KDE: Enable more tests Hartmut Goebel
2019-01-02 18:46 ` [bug#33955] [PATCH 1/6] gnu: kcoreaddons: Enable test-suite Hartmut Goebel
2019-01-02 18:46   ` Hartmut Goebel [this message]
2019-01-02 18:46   ` [bug#33955] [PATCH 3/6] gnu: kpackage: " Hartmut Goebel
2019-01-02 18:46   ` [bug#33955] [PATCH 4/6] gnu: kemoticons: " Hartmut Goebel
2019-01-02 18:46   ` [bug#33955] [PATCH 5/6] gnu: knewstuff: " Hartmut Goebel
2019-01-02 18:46   ` [bug#33955] [PATCH 6/6] gnu: kwindowsystem: " Hartmut Goebel
2019-01-03  1:59 ` [bug#33955] [PATCH 0/6] KDE: Enable more tests Meiyo Peng
2019-01-03 19:40   ` [bug#33951] " Hartmut Goebel
2019-01-04  1:16     ` Meiyo Peng
2019-01-04  9:27       ` bug#33951: " Hartmut Goebel
2019-01-14 21:50 ` Ludovic Courtès
2019-01-16 23:20   ` bug#33955: " Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102184650.8075-2-h.goebel@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=33955@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).