From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYVFw-00074X-3j for guix-patches@gnu.org; Sun, 16 Dec 2018 07:10:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYV1e-0004US-9j for guix-patches@gnu.org; Sun, 16 Dec 2018 06:56:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:45674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYV1d-0004UB-Vs for guix-patches@gnu.org; Sun, 16 Dec 2018 06:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYV1d-0006tH-Mm for guix-patches@gnu.org; Sun, 16 Dec 2018 06:56:01 -0500 Subject: [bug#33756] correction Resent-Message-ID: Date: Sun, 16 Dec 2018 12:55:12 +0100 From: Danny Milosavljevic Message-ID: <20181216125512.132a3e41@scratchpost.org> In-Reply-To: <20181215164915.GA1300@antelope> References: <20181215070959.2260-1-namn@berkeley.edu> <20181215164915.GA1300@antelope> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/GM.QnqEZCCImDl+wb=lgdSz"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nam Nguyen Cc: 33756@debbugs.gnu.org --Sig_/GM.QnqEZCCImDl+wb=lgdSz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, thanks for the patch. I have the following suggestions: * It's easier to just use #:make-flags to override the CC make variable -- = and it doesn't require a custom phase * It's clearer to use #:tests? #f to indicate that there are no tests. * install-file makes sure that the destination directory exists already, so it's useless to manually create it * sctd.sh uses "which" to find the "sct" executable. Please patch it so that it uses the sct executable of (assoc-ref outputs "out") "/bin" (i.e. hard-code it) instead * sctd.sh uses "logger" which is part of inetutils, so inetutils should be a regular input. Moreover, please patch sctd.sh so it uses inetutils' logger (i.e. hard-code it using (assoc-ref inputs "inetutils")) * sctd.sh uses "date", "printf" and "sleep" which are part of coreutils, so coreutils should be a regular input. Moreover, please patch sctd.sh so it uses coreutils' things (i.e. hard-code it using (assoc-ref inputs "coreu= tils") (See other files for how to use "substitute*" to patch things) Could you send an updated patch? --Sig_/GM.QnqEZCCImDl+wb=lgdSz Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlwWPSAACgkQ5xo1VCww uqX/cwf9H+JpdKrZWip8HjERaOK890Xy0Yr1wsE0YxOeTBsUt8CCeGVxOzo3ZIll fxU2ImVRQoU7iilig/6DaONl/ExCqzAyR1ahFQDeB4JS8OZZ5Hg7s8QwRIe7d3nb //wANwwFR78I8f6yvnehu7lQ66ydroLXKisGGV/fbp2Pgii5LN79Mn60bwE0/13J GRkWt7ey/BM1VmoSeZDzNTzJ5VjM0o7sTzv7ubmDcUMWoUi1B0BpGfOPBIPLhX9u o3UmlUdzIgzhAnZUtmiLdXUo595nGD5R0HowGdcIiQI0qkoCKoS9fBHJ+zl4czdJ 1J3gxB3bHbXMDrMfzRJPd/JsZrIdvg== =42Vo -----END PGP SIGNATURE----- --Sig_/GM.QnqEZCCImDl+wb=lgdSz--